test: Add REST tests for explicitly-retired / non-active lifecycle records#106
Open
wulansari999 wants to merge 1 commit into
Open
test: Add REST tests for explicitly-retired / non-active lifecycle records#106wulansari999 wants to merge 1 commit into
wulansari999 wants to merge 1 commit into
Conversation
…cords (search) (Fixes lance-format#105) Implements integration tests mirroring the supersession tests to verify that search results correctly hide explicitly retired or non-active lifecycle status records by default, and correctly surface them when `include_retired=true`.
Collaborator
|
This currently fails CI in clippy because the new tests do not match the current API:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105.
Problem Statement:
Explicit retirement (
retired_at) and non-active lifecycle status (e.g.Contradicted) behaviors were lacking REST layer test coverage for thesearchendpoint.Technical Solution:
search_respects_explicit_retirementtosearch.rstest suite.search_respects_non_active_lifecycle_statustosearch.rstest suite.include_retired = trueis passed.Testing Performed:
cargo fmt.Related Issue:
Resolves #105