refactor(index): introduce RowIdRemapper trait to decouple ScalarIndexPlugin from FragReuseIndex#7394
Open
westonpace wants to merge 2 commits into
Open
Conversation
…xPlugin from FragReuseIndex Replaces the concrete `FragReuseIndex` parameter in `ScalarIndexPlugin::load_index` and `get_from_cache` with an abstract `RowIdRemapper` trait, removing the direct dependency of scalar index infrastructure on the table-level fragment-reuse type. `FragReuseIndex` implements the new trait and the call site in lance casts before passing through. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
westonpace
force-pushed
the
refactor/fri-to-remapper-trait
branch
from
3dbd27d to
8aa5b43
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Xuanwo
approved these changes
Jun 24, 2026
Xuanwo
left a comment
Xuanwo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, need to address the conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the concrete
FragReuseIndexparameter inScalarIndexPlugin::load_indexandget_from_cachewith an abstractRowIdRemappertrait, removing the direct dependency of scalar index infrastructure on the table-level fragment-reuse type.FragReuseIndeximplements the new trait and the call site in lance casts before passing through.