perf(fts): prewarm larger chunks concurrently#7436
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
822b129 to
1675891
Compare
Xuanwo
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance Improvement
What is the performance issue or bottleneck?
FTS prewarm was reading posting lists in very small chunks. For large FTS indexes this can create thousands of range reads, so remote-read scheduling and per-chunk build overhead dominate prewarm time.
How does this PR improve performance?
This PR uses larger bounded chunks and bounded read/build concurrency:
with_position=truecache behavior.This keeps prewarm bounded without using a whole-file fast path or runtime memory-budget probing.
Benchmark or measurement results:
On the large FTS prewarm benchmark used for validation:
Validation
cargo fmt --allgit diff --checkcargo test -p lance-index prewarm -- --nocapturecargo clippy --all --tests --benches -- -D warnings