feat(fts): add configurable posting block size#7466
Draft
BubbleCal wants to merge 3 commits into
Draft
Conversation
Contributor
|
Important This PR touches the Lance format specification. Substantive changes to the format specification — the If this is a meaningful format change:
|
dd4ac88 to
d9f0acb
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
d9f0acb to
23e4810
Compare
23e4810 to
059ae90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Linear: OSS-1344
What is the new feature?
FTS inverted index creation now accepts a
block_sizeparameter for compressed posting blocks. Supported values are128and256.Why do we need this feature?
The posting block size was previously fixed at
128, which made the block-max granularity impossible to tune for different datasets and query profiles.How does it work?
block_sizetoInvertedIndexParams, protobuf details, posting-list schema metadata, and cache headers.256as the default for newly created indexes.block_sizeas legacy128.512, with a clear validation error.Validation
cargo fmt --allcargo fmt --all --checkgit diff --checkCARGO_TARGET_DIR=/tmp/lance-target-a479-no512 cargo test -p lance-index block_size -- --nocaptureCARGO_TARGET_DIR=/tmp/lance-target-a479-no512 cargo clippy -p lance-index --tests -- -D warningsuv run make buildfrompython/uv run pytest python/tests/test_scalar_index.py::test_create_scalar_index_fts_block_sizefrompython/uv run ruff format --check python/tests/test_scalar_index.py python/lance/dataset.pyfrompython/uv run ruff check python/tests/test_scalar_index.py python/lance/dataset.pyfrompython/Not run locally: Java focused test / spotless check, because this machine has no Java Runtime installed (
Unable to locate a Java Runtime).