fix: convert Arrow JSON to Lance JSON in single-fragment create path#7469
Open
xloya wants to merge 1 commit into
Open
fix: convert Arrow JSON to Lance JSON in single-fragment create path#7469xloya wants to merge 1 commit into
xloya wants to merge 1 commit into
Conversation
xloya
force-pushed
the
upstream-pr/json-fragment-create
branch
from
b53c9e4 to
e015f64
Compare
xloya
force-pushed
the
upstream-pr/json-fragment-create
branch
from
e015f64 to
ad85b9e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating a single fragment via
LanceFragment.create/FragmentCreateBuilderwith an Arrow JSON column (arrow.json, stored as Utf8) writes raw UTF-8 bytes into a column whose schema declares Lance JSON (JSONB / LargeBinary), corrupting subsequent reads.Root cause
The multi-fragment and dataset write paths run the Arrow JSON -> Lance JSON conversion via
do_write_fragments. The single-fragment create path skipped it.Fix
Run the same conversion in the create path via
SchemaAdapter::to_physical_stream.Test
test_fragment_create_with_json_column(Python).