fix: return Arrow JSON from FileFragment.take#7471
Open
xloya wants to merge 1 commit into
Open
Conversation
xloya
force-pushed
the
upstream-pr/json-dataset-fragment-take
branch
from
e4683e4 to
6a92052
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FileFragment.take(and dataset take) returns JSON columns as raw Lance JSONB instead of the logical Arrow JSON type.Root cause
The take path returned the stored Lance JSON (LargeBinary/JSONB) bytes without converting back to Arrow JSON (Utf8).
Fix
After
take_rows, convert Lance JSON columns back to Arrow JSON viaconvert_lance_json_to_arrowwhen JSON fields are present.Test
Python
test_take_with_json_column(dataset) andtest_fragment_take_with_json_column.