fix: convert Arrow JSON when updating columns via merge/update path#7472
Open
xloya wants to merge 1 commit into
Open
fix: convert Arrow JSON when updating columns via merge/update path#7472xloya wants to merge 1 commit into
xloya wants to merge 1 commit into
Conversation
7de1961 to
9939817
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Updating an Arrow JSON column through
fragment.update_columns/ the update merge path fails with a type-mismatch error.Root cause
The HashJoiner right-side stream did not convert Arrow JSON (Utf8) to Lance JSON (LargeBinary/JSONB) before joining.
Fix
Wrap the right-side stream in a
JsonConvertingReaderthat converts Arrow JSON fields to Lance JSON before the join.Test
Python
test_fragment_update_columns_with_json_columnplus dataset update tests.