feat(logi): support HID++ button gestures - #1
Open
LJAYi wants to merge 2 commits into
Open
Conversation
Route Logitech HID++ button events through the gesture state machine, register actionable gesture CIDs for diversion, and preserve ordinary button actions for gesture-button taps. Normalize persisted triggers so state flags do not create duplicate rules.
Replace the separate bindings/gestures modes with disclosure rows, keep the standard add/remove controls usable, and base duplicate feedback on existing button rules. Add a focused storyboard regression test for expansion and deletion.
Author
|
I tested this with a Logitech M720 and added HID++ support for its MultiPlatform Gesture button, including directional gestures, inline configuration, and Back/Forward button fixes. If these changes are incorporated into Caldis#922, I’d appreciate it if my commit authorship could be preserved when merging. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation notes
HID++ button events do not carry a
CGEvent, soGestureProcessornow accepts the sharedInputEventrepresentation and keeps replay context optional. Native mouse triggers still replay their original click when appropriate, while HID++ triggers fall back to the configured button action.Only enabled bindings with a real action reserve and divert a Logitech CID. Trigger modifiers are normalized before persistence and comparison so state flags such as Caps Lock cannot create visually identical duplicate rules.
Testing
scripts/qa/lint-logi-boundary.shGestureProcessorTests,ButtonBindingTests,LogiUsageBootstrapTests, andInputProcessorTestsCODE_SIGNING_ALLOWED=NOScreenshot