test: remove secrets from PR integration tests - #484
Open
AaronFeledy wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for lando-core ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Removes repository-secret requirements from the GitHub init and plugin Leia tests so they can run for fork pull requests.
init-githubLeia test to use a public HTTPS clone without mutating a real GitHub accountinit-githubandpluginscoverage for fork PRsThe
l337andlando-v4suites continue to be skipped on forks because they intentionally verify authenticated SSH cloning. Trusted branches retain that coverage with the deploy key.SSH GitHub initialization remains unchanged and is covered alongside the new HTTPS behavior by unit tests.
Testing
npm-profilelogin flowgit diff --checkThe exact Docker-backed Verdaccio Leia flow is left to CI because Docker is not installed in the local execution environment.