Skip to content

fix: check out privileged test commits from base repo pull refs - #487

Merged
AaronFeledy merged 1 commit into
mainfrom
fix/privileged-tests-base-checkout
Aug 9, 2026
Merged

fix: check out privileged test commits from base repo pull refs#487
AaronFeledy merged 1 commit into
mainfrom
fix/privileged-tests-base-checkout

Conversation

@AaronFeledy

Copy link
Copy Markdown
Member

What does this do?

Fixes the privileged Leia test dispatch failing with Version 6209 must be semver valid! (https://github.com/lando/core/actions/runs/31334820529).

The job checked out the fork repository directly, but forks don't carry upstream tags, so prepare-release-action had no v* tag to derive a dev version from and choked on the raw commit SHA.

Now the job checks out the base repository (tags present) and fetches the reviewed commit via pull/N/head, which lives in the base repo. This also removes the head-repo API lookup and keeps working if the fork is deleted. The security property is unchanged: the job still checks out the exact maintainer-reviewed SHA, validated against the current PR head.

Testing

@netlify

netlify Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deploy Preview for lando-core ready!

Name Link
🔨 Latest commit 60a2170
🔍 Latest deploy log https://app.netlify.com/projects/lando-core/deploys/6a78e847979a260008470641
😎 Deploy Preview https://deploy-preview-487--lando-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 12 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@AaronFeledy
AaronFeledy merged commit 4306d5e into main Aug 9, 2026
75 checks passed
@AaronFeledy
AaronFeledy deleted the fix/privileged-tests-base-checkout branch August 9, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant