Skip to content

feat(integrations): add lfx connection resolution contract - #14919

Open
erichare wants to merge 2 commits into
feat/int-1-discovery-gatefrom
fix/le-2460-connection-contract
Open

feat(integrations): add lfx connection resolution contract#14919
erichare wants to merge 2 commits into
feat/int-1-discovery-gatefrom
fix/le-2460-connection-contract

Conversation

@erichare

@erichare erichare commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

  • add the provider-neutral ConnectionRefInput, resolver protocol, and lazy credential lease
  • add fail-closed resolver discovery plus request/environment resolution for headless lfx execution
  • add typed, sanitized integration errors, capability metadata, and identifier-free telemetry
  • stamp and propagate an in-memory execution principal without serializing it into graph payloads

This PR is stacked on #14906 (INT-1) and targets release-1.13.0 transitively. It should be retargeted to release-1.13.0 after #14906 merges.

Verification

  • uv run ruff check .
  • uv run pytest tests/unit/integrations tests/unit/services/connection tests/unit/extension/test_manifest.py tests/unit/extension/test_schema.py tests/unit/services/test_service_manager.py tests/unit/inputs/test_inputs_schema.py tests/unit/custom/custom_component/test_component.py -q (220 passed, 1 xfailed)
  • uv run --package lfx python scripts/migrate/check_bundle_api_changelog.py --base origin/feat/int-1-discovery-gate

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • release-.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 8102d1d2-71e9-4a9c-80ee-64820b8e91ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the enhancement New feature or request label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

✅ Test Coverage Advisor

No source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉

Advisory check only — never blocks merge.

@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.37226% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.53%. Comparing base (be623cc) to head (47c482e).

Files with missing lines Patch % Lines
...rc/lfx/src/lfx/services/connection/env_resolver.py 63.63% 23 Missing and 9 partials ⚠️
src/lfx/src/lfx/services/manager.py 25.92% 18 Missing and 2 partials ⚠️
src/lfx/src/lfx/integrations/capabilities.py 82.10% 11 Missing and 6 partials ⚠️
src/lfx/src/lfx/integrations/errors.py 83.49% 10 Missing and 7 partials ⚠️
src/lfx/src/lfx/integrations/models.py 87.28% 10 Missing and 5 partials ⚠️
src/lfx/src/lfx/services/deps.py 51.61% 12 Missing and 3 partials ⚠️
src/lfx/src/lfx/integrations/telemetry.py 70.21% 13 Missing and 1 partial ⚠️
src/lfx/src/lfx/cli/validation/_env_validation.py 77.41% 4 Missing and 3 partials ⚠️
...c/lfx/src/lfx/custom/custom_component/component.py 66.66% 4 Missing and 2 partials ⚠️
src/lfx/src/lfx/run/base.py 33.33% 3 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           feat/int-1-discovery-gate   #14919      +/-   ##
=============================================================
+ Coverage                      66.45%   66.53%   +0.07%     
=============================================================
  Files                           2499     2515      +16     
  Lines                         259913   262282    +2369     
  Branches                       36772    36857      +85     
=============================================================
+ Hits                          172736   174497    +1761     
- Misses                         85009    85575     +566     
- Partials                        2168     2210      +42     
Flag Coverage Δ
backend 74.12% <100.00%> (-0.08%) ⬇️
lfx 65.09% <76.96%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/backend/base/langflow/services/factory.py 85.50% <100.00%> (+0.43%) ⬆️
src/backend/base/langflow/services/schema.py 100.00% <100.00%> (ø)
...backend/base/langflow/services/telemetry/schema.py 97.74% <100.00%> (+0.14%) ⬆️
src/lfx/src/lfx/graph/graph/base.py 65.54% <100.00%> (+0.08%) ⬆️
src/lfx/src/lfx/inputs/input_mixin.py 82.74% <100.00%> (+0.62%) ⬆️
src/lfx/src/lfx/io/schema.py 66.15% <100.00%> (+0.70%) ⬆️
src/lfx/src/lfx/run/_defaults.py 92.30% <100.00%> (+0.41%) ⬆️
src/lfx/src/lfx/services/authorization/base.py 86.81% <100.00%> (+1.38%) ⬆️
src/lfx/src/lfx/services/interfaces.py 100.00% <100.00%> (ø)
src/lfx/src/lfx/services/schema.py 100.00% <100.00%> (ø)
... and 15 more

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 55%
55.65% (84754/152292) 72.47% (12552/17320) 50.95% (2000/3925)

Unit Test Results

Tests Skipped Failures Errors Time
6641 0 💤 0 ❌ 0 🔥 25m 33s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant