[13.x] Support Guzzle 8 and persistent connections across php-fpm requests#60321
Draft
GrahamCampbell wants to merge 1 commit into
Draft
[13.x] Support Guzzle 8 and persistent connections across php-fpm requests#60321GrahamCampbell wants to merge 1 commit into
GrahamCampbell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Guzzle 8, while maintaining Guzzle 7 support. Guzzle 8 comes with a significant new feature: PHP 8.5+ users with ext-curl installed can have connections shared across php-fpm requests. I've implemented this with the following DX:
The
PersistentTransportsurfaces 3 options:None: Do not try and share connections. This is the current behaviour, and remains the default.Preferred: Try to share connections, but if we are not able to, silently fallback toNone.Required: Try to share connections, and if we are not able to, fail loud.Just looking at the Laravel code, it may look like Laravel is controlling the fallback logic, but that is not the full story. Guzzle also handles falling back
Before this PR can be merged, a few things need to happen:
Follow up activities: