fix: classify withdrawn reply targets - #17
Open
liangyu-suli wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The message was withdrawn.response astarget_revokedformat_errorclassification for unrelated HTTP 400 responsesWhy
When a bot replies to a user message that was withdrawn while the handler was running, Feishu may return HTTP 400 without a numeric platform code:
classifyError()previously read only the top-level error message and then classified every HTTP 400 asformat_error. As a result, callers usingisReplyTargetGone()could not fall back to a fresh, unanchored send.Downstream report: zarazhangrui/lark-coding-agent-bridge#260
Downstream defensive fallback: zarazhangrui/lark-coding-agent-bridge#281
Validation
pnpm test— 548 tests passedpnpm typecheck— passedpnpm build— passedpnpm lint— no errors; reports pre-existing warnings/info in unrelated files and a stale Biome schema version