Skip to content

chore: remove unused dependencies across the monorepo#1752

Open
joker23 wants to merge 2 commits into
mainfrom
skz/sdk-2505/remove-unused-deps
Open

chore: remove unused dependencies across the monorepo#1752
joker23 wants to merge 2 commits into
mainfrom
skz/sdk-2505/remove-unused-deps

Conversation

@joker23

@joker23 joker23 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Manifest-only cleanup with no SDK logic changes; main residual risk is CI failing if a removed package was still required indirectly.

Overview
This PR trims package manifests and one Jest config across many SDK, shared, store, and telemetry packages—no application source changes.

Dependency cleanup drops unused devDependencies (notably launchdarkly-js-test-helpers from most packages that no longer import it), redundant type packages (@types/crypto-js where crypto isn’t used locally), and build-only tools that aren’t referenced (extra Rollup plugins, ts-node, Jest extras like jest-diff / @jest/globals). Runtime dependency changes include removing duplicate @launchdarkly/js-server-sdk-common from akamai-base, @launchdarkly/js-sdk-common from openfeature-node-server (left to the common package), crypto-js from vercel (still available via sdk-server-edge), and esm-env from svelte.

openfeature-server-common drops legacy ESLint/Prettier dev tooling and tightens the lint script to npx eslint .. react-native’s Jest config is converted from ESM export default to CommonJS module.exports so Jest can load it without ts-node.

Reviewed by Cursor Bugbot for commit a49004a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes

},
"dependencies": {
"@launchdarkly/akamai-edgeworker-sdk-common": "^2.0.23",
"@launchdarkly/js-server-sdk-common": "^2.19.1"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a transitive dep of @launchdarkly/akamai-edgeworker-sdk-common

},
"devDependencies": {
"@eslint/js": "^9.0.0",
"@rollup/plugin-commonjs": "^25.0.0",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package uses tsc for build.

@joker23 joker23 marked this pull request as ready for review June 16, 2026 20:19
@joker23 joker23 requested a review from a team as a code owner June 16, 2026 20:19

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant