Fix permissions table to use workflow-generated keys.csv#1111
Fix permissions table to use workflow-generated keys.csv#1111rishiraj38 wants to merge 3 commits into
Conversation
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates the csvtable-roles.html and csvtable.html shortcodes to reference the main keys.csv file instead of the backup, adjusts the excluded columns and index ranges, and adds routing logic for academy and learner roles. The review feedback correctly identifies a typo in the prefix check ("leaner" instead of "learner") and points out the redundant and syntactically incorrect use of the or operator with a single argument in both shortcode files.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Rishi Raj <180109771+rishiraj38@users.noreply.github.com>
|
🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1111/
|
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
2c15753 to
4b0ddce
Compare
|
@rishiraj38, could you verify that the workflow has a guard to prevent writing when the CSV/spreadsheet is corrupted or invalid? Since we are removing the backup, we need to make sure a corrupted file cannot be written and end up breaking the docs. |
Description
The permissions shortcodes (
csvtableandcsvtable-roles) were reading a stale, frozenkeys-backup.csvinstead of the auto-generatedkeys.csvthat thegenerate-keys.ymlworkflow refreshes daily from the spreadsheet.Changes
keys.csv(the workflow-generated file)roles/academy-rolesand Learner --roles/academy-roles/#learnerkeys-backup.csvBefore
After
Signed commits