Skip to content

Fix permissions table to use workflow-generated keys.csv#1111

Open
rishiraj38 wants to merge 3 commits into
layer5io:masterfrom
rishiraj38:fix/permissions-csv-shortcodes
Open

Fix permissions table to use workflow-generated keys.csv#1111
rishiraj38 wants to merge 3 commits into
layer5io:masterfrom
rishiraj38:fix/permissions-csv-shortcodes

Conversation

@rishiraj38

Copy link
Copy Markdown
Member

Description

The permissions shortcodes (csvtable and csvtable-roles) were reading a stale, frozen keys-backup.csv instead of the auto-generated keys.csv that the generate-keys.yml workflow refreshes daily from the spreadsheet.

Changes

  • Switch both shortcodes to read keys.csv (the workflow-generated file)
  • Adjust column index ranges to account for the two new role columns (Academy Admin, Learner) present in the current spreadsheet
  • Add link routing for Academy Admin -- roles/academy-roles and Learner -- roles/academy-roles/#learner
  • Remove the stale keys-backup.csv

Before

  • Permissions page displayed outdated data from a frozen CSV copy
  • Academy Admin and Learner columns were missing from the table
  • No role page links for Academy Admin or Learner headers

After

  • Permissions page reflects the latest spreadsheet data via the daily workflow
  • Academy Admin and Learner columns render correctly with proper ✅/❌ indicators
  • Clicking Academy Admin links to Default Academy Roles page; clicking Learner links to the Learner section

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the csvtable-roles.html and csvtable.html shortcodes to reference the main keys.csv file instead of the backup, adjusts the excluded columns and index ranges, and adds routing logic for academy and learner roles. The review feedback correctly identifies a typo in the prefix check ("leaner" instead of "learner") and points out the redundant and syntactically incorrect use of the or operator with a single argument in both shortcode files.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread layouts/shortcodes/csvtable-roles.html Outdated
Comment thread layouts/shortcodes/csvtable.html Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Rishi Raj <180109771+rishiraj38@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1111/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
@rishiraj38 rishiraj38 force-pushed the fix/permissions-csv-shortcodes branch from 2c15753 to 4b0ddce Compare June 22, 2026 15:18
@PragalvaXFREZ

Copy link
Copy Markdown
Contributor

@rishiraj38, could you verify that the workflow has a guard to prevent writing when the CSV/spreadsheet is corrupted or invalid?

Since we are removing the backup, we need to make sure a corrupted file cannot be written and end up breaking the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants