-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: google search indexing for 404 urls #7827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -229,5 +229,87 @@ redirects: | |
| isPermanent: true | ||
| - fromPath: "/cloud-native-management/playground.html" | ||
| toPath: "https://www.kanvas.new" | ||
| - fromPath: "/serivce-mesh-landscape" | ||
| toPath: "/service-mesh-landscape" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/projects/catalog" | ||
| toPath: "/cloud-native-management/catalog" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/community/newcomer" | ||
| toPath: "/newcomers" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/learn/service-mesh-labs/working-with-meshery-and-consul" | ||
| toPath: "/learn/kanvas-labs/working-with-meshery-and-consul" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/learn/service-mesh-workshops/all-things-open-2019" | ||
| toPath: "/learn/workshops" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/learn/service-mesh-workshops/cloud-native-austin-2020" | ||
| toPath: "/learn/workshops" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/blog/engineering" | ||
| toPath: "/blog" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What? I think you mean: |
||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/meshery/adapters" | ||
| toPath: "/cloud-native-management/meshery" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/cloud-native-management" | ||
| toPath: "/cloud-native-management/meshery" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/cloud-native-management/" | ||
| toPath: "/cloud-native-management/meshery" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/solutions/devrel-platform" | ||
| toPath: "/solutions/devrel-platform-for-kubernetes-and-cloud-native-content" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/2018/06/07/istio-up-and-running/" | ||
| toPath: "/learn/service-mesh-books/istio-up-and-running" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/community/handbook/faq" | ||
| toPath: "/community/handbook/faqs" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/community/handbook/designer" | ||
| toPath: "/community/handbook/design-with-layer5" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/community/handbook/community" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Whoa! Whoa, whoa. Read this again, @Oluwatunmise-olat. This would be disastrous.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| toPath: "/community/handbook/community-guidelines" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/community/handbook/learn-layer5" | ||
| toPath: "/community/handbook/learning" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/community/handbook/instructions" | ||
| toPath: "/community/handbook" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/community/handbook/contributor-journey" | ||
| toPath: "/community/handbook" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/learn/service-mesh-labs/working-with-meshery-and-istio" | ||
| toPath: "/learn/kanvas-labs/working-with-meshery-and-istio" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/learn/service-mesh-workshops/service-mesh-fundamentals-with-linkerd" | ||
| toPath: "/learn/workshops" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| - fromPath: "/carrer" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No. Why would we want to support a misspelling? If it is a misspelling on a property that we own, let's fix it at the source, otherwise, there's no sense in fixing all of the world's misspellings that are pointed to us from whatever site they run or blog post they make. We can't control that and shouldn't try. We need an enhanced error page that facilitates the reporting of issues. That would be an improvement to help handle all of the possible unknown 404s pointed our way. Will you open an issue to track this enhancement, @Oluwatunmise-olat?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would open an issue for this. That is a valid point |
||
| toPath: "/careers" | ||
| redirectInBrowser: true | ||
| isPermanent: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /*.html /:splat 301 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Oluwatunmise-olat what is the use of this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @saurabhraghuvanshii Search Console flagged a bunch of 404s for pages with .html at the end, like /blog/post.html. It looks like these are coming from old cached links and external sites that still think we're using that format. It is a wildcard redirect that strips the .html suffix and sends a permanent redirect to the clean path |
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this should be
/community/newcomers.Where is the source of this hyperlink? Someone or some site didn't include the "s".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was coming from
static/mail/2026/lfx-2026.htmlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the source right now