QL_REQUIRE_EXPLICIT_EVALUATION_DATE#2644
Open
kp9991-git wants to merge 2 commits into
Open
Conversation
|
coverage: 74.885%. remained the same — kp9991-git:EvalDateForced into lballabio:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the evaluation date is not set, it defaults to today. In some cases it can be a problem because defaulting to a date that the user failed to set (but potentially expects) can result in subtle pricing errors that are not immediately obvious. This PR introduces a compile-level flag in QL_REQUIRE_EXPLICIT_EVALUATION_DATE in userconfig.hpp. When set, accessors to the evaluation date (if it has not been set) will fail, helping the user see that something is wrong.