Print all failed assertion expressions#4489
Open
roystgnr wants to merge 2 commits into
Open
Conversation
We print all the specialized assertions' expressions, but in the general case we've apparently just been relying on file/line output, which is less friendly.
Member
Author
|
And to boot, our file/line-number output is a bit obscured, because we print it after the stack trace, which only lists function names. Maybe I should move that while I'm at it... |
Two experienced developers today (including myself) both failed to notice that we were printing this data at all, because our eyes glazed over after a dozen or two stack frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We print all the specialized assertions' expressions, but in the general case we've apparently just been relying on file/line output, which is less friendly.