Skip to content

Fixes and code cleanup for include/pfn/expected.hpp #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bronek wants to merge 20 commits into
base: main
Choose a base branch
from

MSVC workaround for buggy std::is_nothrow_* implementation

553f03c
Select commit
Loading
Failed to load commit list.
Open

Fixes and code cleanup for include/pfn/expected.hpp #189

MSVC workaround for buggy std::is_nothrow_* implementation
553f03c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 8, 2026 in 49s

Quality Gate failed

Failed conditions
19.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 3527 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrP&open=AZ4EKQw6I8ZoIQNOaUrP&pullRequest=189

Check warning on line 2193 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUq4&open=AZ4EKQw6I8ZoIQNOaUq4&pullRequest=189

Check failure on line 57 in tests/util/helper_types.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The move assignment operator of "helper_t" should be unconditionally declared as "noexcept". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQtbI8ZoIQNOaUqH&open=AZ4EKQtbI8ZoIQNOaUqH&pullRequest=189

Check warning on line 1618 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqw&open=AZ4EKQw6I8ZoIQNOaUqw&pullRequest=189

Check warning on line 2284 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrA&open=AZ4EKQw6I8ZoIQNOaUrA&pullRequest=189

Check warning on line 3744 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrX&open=AZ4EKQw6I8ZoIQNOaUrX&pullRequest=189

Check warning on line 1741 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "b" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqc&open=AZ4EKQw6I8ZoIQNOaUqc&pullRequest=189

Check warning on line 4282 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrp&open=AZ4EKQw6I8ZoIQNOaUrp&pullRequest=189

Check warning on line 1983 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUq1&open=AZ4EKQw6I8ZoIQNOaUq1&pullRequest=189

Check warning on line 39 in tests/util/helper_types.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQtbI8ZoIQNOaUqI&open=AZ4EKQtbI8ZoIQNOaUqI&pullRequest=189

Check warning on line 3528 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrQ&open=AZ4EKQw6I8ZoIQNOaUrQ&pullRequest=189

Check warning on line 516 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use an argument to the requires clause to provide a named value instead. 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqW&open=AZ4EKQw6I8ZoIQNOaUqW&pullRequest=189

Check warning on line 3839 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrZ&open=AZ4EKQw6I8ZoIQNOaUrZ&pullRequest=189

Check warning on line 1431 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "a" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqY&open=AZ4EKQw6I8ZoIQNOaUqY&pullRequest=189

Check warning on line 2000 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "c" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqh&open=AZ4EKQw6I8ZoIQNOaUqh&pullRequest=189

Check warning on line 1275 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "a" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqX&open=AZ4EKQw6I8ZoIQNOaUqX&pullRequest=189

Check warning on line 2245 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUq7&open=AZ4EKQw6I8ZoIQNOaUq7&pullRequest=189

Check warning on line 4277 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUro&open=AZ4EKQw6I8ZoIQNOaUro&pullRequest=189

Check warning on line 456 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqO&open=AZ4EKQw6I8ZoIQNOaUqO&pullRequest=189

Check warning on line 3628 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrR&open=AZ4EKQw6I8ZoIQNOaUrR&pullRequest=189

Check warning on line 1266 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqo&open=AZ4EKQw6I8ZoIQNOaUqo&pullRequest=189

Check warning on line 4250 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrn&open=AZ4EKQw6I8ZoIQNOaUrn&pullRequest=189

Check warning on line 1422 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqr&open=AZ4EKQw6I8ZoIQNOaUqr&pullRequest=189

Check warning on line 1119 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUqi&open=AZ4EKQw6I8ZoIQNOaUqi&pullRequest=189

Check warning on line 3915 in tests/pfn/expected.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace alternative operator "not" with "!". 

See more on https://sonarcloud.io/project/issues?id=libfn_functional&issues=AZ4EKQw6I8ZoIQNOaUrd&open=AZ4EKQw6I8ZoIQNOaUrd&pullRequest=189
View more details on SonarQubeCloud