Add openbios.bin to mednafen_psx_libretro.info, and mednafen_psx_hw_libretro.info - #2029
Add openbios.bin to mednafen_psx_libretro.info, and mednafen_psx_hw_libretro.info#2029davidhedlund wants to merge 8 commits into
openbios.bin to mednafen_psx_libretro.info, and mednafen_psx_hw_libretro.info#2029Conversation
ConsiderationsRegionCurrently, it displays "(PS1 OpenBIOS)". But it is a multi-region BIOS that even supports Asian regions (corresponding to scph5003.bin) so should it instead display "(PS1 AS/EU/JP/US OpenBIOS)"? MD5sumIt displays
References1: How do download openbios.bin
|
|
Another somewhat related consideration, is if the region specific bios files really still need to be called required now that the builtin openbios is available as a fallback. |
group openbios.bin with region-free BIOSes.
group openbios.bin with region-free BIOSes.
Set openbios.bin to optional (the inbuilt version of OpenBIOS is used as fallback)
Set openbios.bin to optional (the inbuilt version of OpenBIOS is used as fallback)
Yeah! OpenBIOS is inbuilt and supports multiple regions. But can you please give feedback to this before I change
|
|
I don't know the conventions for the descriptions, but it could be made to match PSP and PS3 and be (OpenBIOS PS1 BIOS) |
Yeah, let's keep the current revision for that. |
|
typo in PR description openbiox.bin -> openbios.bin |
Set all `firmware*_opt` values to `false`: You no longer need to place a BIOS file in the System/BIOS directory, because OpenBIOS is built-in and serves as a fallback.
Set all `firmware*_opt` values to `false`: You no longer need to place a BIOS file in the System/BIOS directory, because OpenBIOS is built-in and serves as a fallback.
openbio.bin to Beetle PSX (mednafen_psx_libretro.info), and Beetle PSX HW (mednafen_psx_hw_libretro.info)
Fixed. Thanks for all the helpful feedback! |
openbio.bin to Beetle PSX (mednafen_psx_libretro.info), and Beetle PSX HW (mednafen_psx_hw_libretro.info)openbios.bin to mednafen_psx_libretro.info, and mednafen_psx_hw_libretro.info
openbios.bin to mednafen_psx_libretro.info, and mednafen_psx_hw_libretro.infoopenbios.bin to mednafen_psx_libretro.info, and mednafen_psx_hw_libretro.info
I think md5: varies is fine, it hints to the user that there is no single openbios.bin version, another option that kinda fits the spirit of this is mentioning the source file location the user can use to compare checksums. |
|
I think the PR is ready to get merged now but I wait for @hizzlekizzle to review it too. |
|
I was thinking about a link to pcsx-redux or https://docs.libretro.com/library/beetle_psx/#bios, maybe just "see bios section in the docs" Then a future improvement is some instructions can be added to https://github.com/libretro/docs/blob/master/docs/library/beetle_psx.md and beetle_psx_hw.md to help users extract the openbios.bin |
Yeah, I've mentioned how to do that in multiple issues over the years (including #2029 (comment)) but I never documented it. So I just submitted this PR: Thanks! |



Users should be notified whether openbios.bin file has been loaded from the System/BIOS directory under Main Menu → Information → Core Information the under
Firmwaresection.Fixes:
Main Menu → Information → Core InformationresultsWith openbios.bin added to the System/BIOS directory
Indicates that external OpenBIOS is used:
Without openbios.bin added to the System/BIOS directory
Indicates that the inbuilt version of OpenBIOS is used:
Additional information
If these commits are approved, openbios.bin should also be added to:
Reviewers
@hizzlekizzle @ZachCook