vfs: Apply the Virtual File System further - #929
Conversation
RobLoach
changed the title
|
I'm not sure we really need large files, but it doesn't hurt either I guess. Can you squash the last commit with the 3rd and force-push? |
| * returns the new file position. We adapt the return value to the | ||
| * fseek semantics (0 on success, -1 on error), so callers that test the | ||
| * result against 0 work under both stdio and VFS. */ | ||
| return core_stdio_fseek_impl((FILE*)file->argp, offset, whence) < 0 ? -1 : 0; |
There was a problem hiding this comment.
You need to send this upstream to https://github.com/rtissera/libchdr and then I'll update the whole libchdr. Otherwise this change will be lost on next libchdr update.
There was a problem hiding this comment.
Good call. Was not quite sure where to push the upstream changes.
There was a problem hiding this comment.
Pushed upstream at rtissera/libchdr#166 by using the macro. Seems a bit cleaner, both approaches work.
There was a problem hiding this comment.
merging it after CI greenlights, thanks
There was a problem hiding this comment.
Looks like the the failure was a GitHub Actions timeout. Other builds are passing. Lemme know if you think there's anything we should clean up.
Moved back to V3 👍
My squash jitsu isn't that solid, and worry I'd break things more. Are you able to just squash the whole thing on merge instead? I could cherry-pick the libretro-common update in a different PR if that helps. 
|
|
That would squash everything instead of those few commits. Anyway I can take care of this myself after libchdr changes get merged in its repo. |
3 participants
This applies the Virtual File System further, updating to VFS4 to support for larger file sizes with seek_64. The diff is large because of the libretro-common update for VFS4 support.