Conversation
sjaeckel
reviewed
May 19, 2026
| LTC_ARGCHK(key != NULL); | ||
|
|
||
| if ((err = s_sm2_only_curve(key)) != CRYPT_OK) return err; | ||
| if ((hash_idx = s_sm2_hash_idx(hash_idx)) < 0) return hash_idx; |
Member
There was a problem hiding this comment.
This error check won't work.
I'd say we can remove the hash_idx in the API. This also applies to ecc_decrypt_key_sm2().
Comment on lines
+474
to
+484
| int ecc_sign_sm2(const unsigned char *id, unsigned long idlen, | ||
| const unsigned char *msg, unsigned long msglen, | ||
| unsigned char *out, unsigned long *outlen, | ||
| prng_state *prng, int wprng, int hash_idx, | ||
| const ecc_key *key); | ||
|
|
||
| int ecc_verify_sm2(const unsigned char *id, unsigned long idlen, | ||
| const unsigned char *msg, unsigned long msglen, | ||
| const unsigned char *sig, unsigned long siglen, | ||
| int hash_idx, int *stat, const ecc_key *key); | ||
|
|
Member
There was a problem hiding this comment.
Would it maybe make sense to introduce a new generic API?
Add LTC_ECCSIG_SM2 to ecc_signature_type and hash_idx to ltc_ecc_sig_opts and then have the following:
int ecc_sign_data(const unsigned char *data,
unsigned long datalen,
unsigned char *sig,
unsigned long *siglen,
ltc_ecc_sig_opts *opts,
const ecc_key *key);
int ecc_verify_data(const unsigned char *sig,
unsigned long siglen,
const unsigned char *data,
unsigned long datalen,
ltc_ecc_sig_opts *opts,
int *stat,
const ecc_key *key);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SM2 (Chinese public key algorithm) support.
It depends on the not-yet-merged SM3 hash support.
SM2 uses the existing ECC curve code where possible (it is just another curve). However, its signing/encryption work differently enough, so this patch adds separate SM2-specific functions.
Checklist