Repository navigation
Conversation
Its only caller was `registerFacetToDiamond`, removed in #2327. Nothing in the repo has called it since. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0xDEnYO
marked this pull request as ready for review
September 21, 2026 02:24
3 of 5 tasks
0xDEnYO
enabled auto-merge (squash)
September 21, 2026 03:15
Contributor
Author
|
Folded into #2433 — its commits are now on that branch, so this PR is closed to keep the review queue to one unit per subsystem. No work is lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task belongs to this PR?
None — follow-up to #2327 (EXSC-920).
Why did I implement it this way?
verifyFacetRegistrationlost its only caller when #2327 removedregisterFacetToDiamond. Nothing has called it since onmain, nor on either open Tron branch (#2409, #2427), which both carry it unreferenced at the same line.Three older open branches (#2092, #2417, #1940) do still contain a caller, in their own copy of
tronUtils.ts. They are 85–413 commits behind and simply predate #2327, which deleted the callingregisterFacetToDiamond; mergingmainresolves each to that deletion. No in-flight work depends on the helper.No post-cut verification is lost with it. The live registration path verifies inline and more thoroughly:
register-facets-to-diamond.ts:256re-reads the loupe after each cut and only records a facet intron.diamond.jsonif it actually shows up, and the "Final verification" pass at:531diffs the whole facet list against the expected set and warns on anything missing. The deleted helper returned a boolean for one facet.Removing the function leaves
tryTronFacetLoupeAddressToBase58unused in this file;register-facets-to-diamond.tsimports it separately and is untouched. The file header no longer claims facet/whitelist verification, sincecheckOwnershipTronis the only health check left in it.Checklist before requesting a review
🤖 Generated with Claude Code