Skip to content

refactor(tron): drop the dead verifyFacetRegistration helper - #2431

Closed
0xDEnYO wants to merge 1 commit into
mainfrom
chore/remove-dead-verify-facet-registration
Closed

0xDEnYO wants to merge 1 commit into
mainfrom
chore/remove-dead-verify-facet-registration

Conversation

@0xDEnYO

@0xDEnYO 0xDEnYO commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Which Linear task belongs to this PR?

None — follow-up to #2327 (EXSC-920).

Why did I implement it this way?

verifyFacetRegistration lost its only caller when #2327 removed registerFacetToDiamond. Nothing has called it since on main, nor on either open Tron branch (#2409, #2427), which both carry it unreferenced at the same line.

Three older open branches (#2092, #2417, #1940) do still contain a caller, in their own copy of tronUtils.ts. They are 85–413 commits behind and simply predate #2327, which deleted the calling registerFacetToDiamond; merging main resolves each to that deletion. No in-flight work depends on the helper.

No post-cut verification is lost with it. The live registration path verifies inline and more thoroughly: register-facets-to-diamond.ts:256 re-reads the loupe after each cut and only records a facet in tron.diamond.json if it actually shows up, and the "Final verification" pass at :531 diffs the whole facet list against the expected set and warns on anything missing. The deleted helper returned a boolean for one facet.

Removing the function leaves tryTronFacetLoupeAddressToBase58 unused in this file; register-facets-to-diamond.ts imports it separately and is untouched. The file header no longer claims facet/whitelist verification, since checkOwnershipTron is the only health check left in it.

Checklist before requesting a review

🤖 Generated with Claude Code

Its only caller was `registerFacetToDiamond`, removed in #2327. Nothing
in the repo has called it since.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 8a519a01-9b95-407c-90df-6f5d3b7b9594

📥 Commits

Reviewing files that changed from the base of the PR and between b2d9f7c and 8e51fad.

📒 Files selected for processing (1)
  • script/deploy/tron/tronUtils.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@0xDEnYO
0xDEnYO marked this pull request as ready for review September 21, 2026 02:24
@0xDEnYO
0xDEnYO requested a review from a team September 21, 2026 02:24
@0xDEnYO
0xDEnYO enabled auto-merge (squash) September 21, 2026 03:15
@0xDEnYO

0xDEnYO commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #2433 — its commits are now on that branch, so this PR is closed to keep the review queue to one unit per subsystem. No work is lost.

@0xDEnYO 0xDEnYO closed this Sep 21, 2026
auto-merge was automatically disabled September 21, 2026 05:02

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants