Skip to content

chore(targetState): pin CalldataVerificationFacet at 1.3.1 on tron (EXSC-1174) - #2557

Draft
gvladika wants to merge 1 commit into
mainfrom
chore/exsc-1174-pin-tron-cvf
Draft

gvladika wants to merge 1 commit into
mainfrom
chore/exsc-1174-pin-tron-cvf

Conversation

@gvladika

Copy link
Copy Markdown
Contributor

Which Linear task belongs to this PR?

Ref EXSC-1174

Why did I implement it this way?

EXSC-1174 rolls CalldataVerificationFacet 2.0.0 out to every production EVM network. Tron is left out because a Tron redeploy costs a lot and 2.0.0 changes little there: it removes the unreachable AcrossV3 branches and adds an offset check in extractNonEVMAddress. Tron is pinned at its current 1.3.1 (per deployments/tron.diamond.json) instead of left on latest. Per docs/TargetState.md, an exact-version pin is how a network is deliberately held back, and the deploy guard and sign-time gate then refuse any other version there. The doc's list of current pins now includes this one.

Tests: bun test on targetStatePinGuard, pinned-target-state and healthCheckInvariants (360 pass). Prettier is clean.

Checklist before requesting a review

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

🤖 Generated with Claude Code

Tron is held back from the CVF 2.0.0 fleet rollout (EXSC-1174).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@gvladika
gvladika requested a review from a team October 15, 2026 11:26
@lifi-action-bot
lifi-action-bot marked this pull request as draft October 15, 2026 11:26
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ce2484b4-5b0f-4ccf-a53a-386abeb9e9fc
📥 Commits

Reviewing files that changed from the base of the PR and between 36a4d10 and 9b370d0.

📒 Files selected for processing: 2
  • docs/TargetState.md
  • script/deploy/_targetState.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants