Repository navigation
chore(GenericSwapFacetV3, WhitelistManagerFacet): roll out v2.0.0 / v1.1.0 (EXSC-1173, EXSC-1177) - #2565
Merged
gvladika merged 2 commits intoOct 20, 2026
Conversation
Testnets (arbitrumsepolia, basesepolia, optimismsepolia) cut directly. 0g, morph, pharos, somnia, telos, tempo proposed to Safe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gvladika
added a commit
that referenced
this pull request
Oct 20, 2026
Regenerated from the on-chain loupe on the 55 networks whose cut executed. The same cuts drained the parked SymbiosisFacet v1.0.0 removals on 11 networks, and the loupe now routes GenericSwapFacetV3 v2.0.0 on morph and telos (#2565). DiamondCutFacet and DiamondLoupeFacet versions were kept at 1.0.0 where the master-log lookup returned none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gvladika
added a commit
that referenced
this pull request
Oct 20, 2026
The loupe sync picked up GenericSwapFacetV3 v2.0.0 on morph, somnia and telos, which #2565 rolls out and records in the flat logs. Restore the previous entries so this PR stays scoped to CalldataVerificationFacet and address-consistency passes; #2565 syncs them when it finishes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tworks (EXSC-1173) Timelock cuts executed on 0g, morph, pharos, somnia, telos and tempo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gvladika
marked this pull request as ready for review
October 20, 2026 06:49
gvladika
enabled auto-merge (squash)
October 20, 2026 06:51
melianessa
approved these changes
Oct 20, 2026
gvladika
added a commit
that referenced
this pull request
Oct 20, 2026
…ks (EXSC-1174) (#2558) * chore(deploy): deploy CalldataVerificationFacet v2.0.0 to 56 networks Safe proposals for the diamondCut are pending signatures (EXSC-1174). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(deploy): sync diamond logs for CalldataVerificationFacet v2.0.0 on 0g, injective, pharos, tempo * chore(deploy): deploy CalldataVerificationFacet v2.0.0 to arbitrumnova, telos and vana Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(deploy): sync diamond logs for CalldataVerificationFacet v2.0.0 Regenerated from the on-chain loupe on the 55 networks whose cut executed. The same cuts drained the parked SymbiosisFacet v1.0.0 removals on 11 networks, and the loupe now routes GenericSwapFacetV3 v2.0.0 on morph and telos (#2565). DiamondCutFacet and DiamondLoupeFacet versions were kept at 1.0.0 where the master-log lookup returned none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(deploy): keep GenericSwapFacetV3 diamond logs for #2565 The loupe sync picked up GenericSwapFacetV3 v2.0.0 on morph, somnia and telos, which #2565 rolls out and records in the flat logs. Restore the previous entries so this PR stays scoped to CalldataVerificationFacet and address-consistency passes; #2565 syncs them when it finishes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Daniela Chybisova <iron.melmel@gmail.com>
gvladika
deleted the
feature/exsc-1173-roll-out-genericswapfacetv3-200-fleet-wide-after-per-diamond
branch
October 20, 2026 07:38
gvladika
added a commit
that referenced
this pull request
Oct 21, 2026
WhitelistManagerFacet 1.1.0 and GenericSwapFacetV3 2.0.0 were deployed and cut on xlayer after #2565 merged, so the flat log kept the old addresses. Match it to the loupe-synced diamond log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 8 tasks
gvladika
added a commit
that referenced
this pull request
Oct 21, 2026
) * chore(deploy): deploy SymbiosisFacet v2.0.0 to X Layer (EXSC-903) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(deploy): sync xlayer diamond log after SymbiosisFacet cut (EXSC-903) Regenerated from the on-chain loupe after timelock op 0xce391f44 executed (tx 0x6cc8d19c). Also picks up WhitelistManagerFacet 1.1.0 and GenericSwapFacetV3 2.0.0, already routed on-chain but not yet logged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(deploy): point xlayer flat log at routed facet versions (EXSC-903) WhitelistManagerFacet 1.1.0 and GenericSwapFacetV3 2.0.0 were deployed and cut on xlayer after #2565 merged, so the flat log kept the old addresses. Match it to the loupe-synced diamond log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Merged
2 of 8 tasks
gvladika
added a commit
that referenced
this pull request
Oct 21, 2026
#2565 listed the wave-2 addresses but did not write them to the flat deployment logs; record them for the 42 networks still on the old facets. EXSC-1173, EXSC-1177 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gvladika
added a commit
that referenced
this pull request
Oct 21, 2026
…nt logs (EXSC-1173) (#2574) * chore(deploy): sync diamond logs for GenericSwapFacetV3/WhitelistManagerFacet Timelock ops from the wave-2 rollout (#2565) executed on all 43 networks; regenerate the production diamond logs from on-chain state. EXSC-1173, EXSC-1177 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(deploy): record GenericSwapFacetV3/WhitelistManagerFacet addresses #2565 listed the wave-2 addresses but did not write them to the flat deployment logs; record them for the 42 networks still on the old facets. EXSC-1173, EXSC-1177 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(deploy): sync wave-3 GenericSwapFacetV3/WhitelistManagerFacet logs Timelock ops for wave 3 (mainnet, arbitrum, base, optimism, polygon, bsc, avalanche) and the arbitrumnova GenericSwapFacetV3 cut executed; regenerate the diamond logs and record the new addresses in the flat logs. EXSC-1173, EXSC-1177 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task belongs to this PR?
Why did I implement it this way?
Deployment logs for the production rollout of GenericSwapFacetV3 v2.0.0 (audit20260519) and WhitelistManagerFacet v1.1.0 (audit20251229). Both are already in
main; this PR only records the new addresses.Every production diamond's on-chain contract-selector whitelist was checked against
config/whitelist.jsonbefore the rollout, and all match. Rollout runs in waves, low-volume chains first.Wave 1: GenericSwapFacetV3 v2.0.0
Wave 2: GenericSwapFacetV3 v2.0.0 + WhitelistManagerFacet v1.1.0
Wave 3: GenericSwapFacetV3 v2.0.0 + WhitelistManagerFacet v1.1.0
The
*.diamond.jsonfiles of Safe-governed chains are updated once their timelock operations execute.Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)
🤖 Generated with Claude Code