Repository navigation
ci: full integration size check and cause of growth in the bundle size report - #513
Merged
Merged
Conversation
Add a full integration check (the main entry with every provider and their dependencies) and checks for the published subpaths. Measure the minified bytes per package next to each size-limit run, and list the packages that explain each notable change in the PR comment.
|
Contributor
📦 Bundle size✅ No significant changes. Every check is within budget. @lifi/sdk
Providers
Full integration
How to read this
|
Do not merge. The next commit reverts this.
This reverts commit 3423b97.
Save the esbuild metafile of the size-limit build instead of bundling each check a second time, so the breakdown always matches the measured bundle. Record bundled copies of a package, log a failed breakdown and never cache it, keep multi-file checks on a base that lacks a file, and flag a change of 5 kB or more on large checks.
chybisov
marked this pull request as ready for review
October 7, 2026 11:42
List the published packages under packages/ and fail the report job when no check measures one of them, so a new provider cannot be added without a size check. A package counts as measured when it is in the breakdown of a measured bundle or a file-only check points into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #511.
What
createClientwith all 7 providers in one bundle, so the total cost of the SDK is visible in one row. Today it is 560.5 kB brotli; the budget is that size plus 20% (673 kB).scripts/size-measure.mjsnow also bundles each check with size-limit's own esbuild and records the minified bytes per package.scripts/size-report.mjsuses this to add a What changed section that lists the packages behind each notable change..size-limit.jsonchecks can now use animportobject with several files.Example
With the
mainfrom before #507 and #510 as the base, the comment would have shown:@noble/curves+42.6 kB,@mysten/sui+24.1 kB,@noble/hashes+11.4 kB,@lifi/sdk-provider-sui+6.39 kBThe scripts are the same files as in lifinance/widget#894 and jumperexchange/jumper-widget#158.
Notes