Repository navigation
chore: version packages - #515
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@lifi/sdk@4.12.0
Minor Changes
#514
5dc9cc5Thanks @chybisov! -LiFiErrorCodehas a new code,CallBundleNotFound(1028). A step fails with this code when the wallet has no record of an EIP-5792 bundle. The SDK uses it only when it cannot prove that the wallet did not send the bundle. The outcome stays unknown: the action keeps the bundle id, and a resume waits for the bundle again and does not sign.ExecutionActionhas a new optional field,callCount. It is the number of calls of a batched (EIP-5792) transaction. The Ethereum provider sets it together withtaskIdfor a batched transaction.@lifi/sdk-provider-bitcoin@4.1.1
Patch Changes
5dc9cc5]:@lifi/sdk-provider-ethereum@4.2.8
Patch Changes
#514
5dc9cc5Thanks @chybisov! - After a user rejected a single-call EIP-5792 bundle in MetaMask, every "Try again" failed with "This bundle id is unknown". The wallet showed no new prompt. MetaMask returns the bundle id before the user approves the bundle. When the user rejects the bundle, MetaMask removes it.Now the SDK uses a new rule for a bundle with one call. If the wallet reports the bundle and then has no record of it in the same wait, the SDK treats the bundle as never sent. The step fails with a final
SignatureRejected. The action keeps the bundle id withtxFinal: true, so the action is closed, and "Try again" signs a new bundle. The SDK uses this rule only for 10 minutes after signing. Some wallets get the bundle status from a remote service, and that service can forget an old bundle.This rule applies only to a bundle with one call. MetaMask returns the id of a bundle with two or more calls only after it sent the bundle. The action stores the number of calls in
callCount, so the rule also works after a page reload. A bundle that the SDK stored before this release has nocallCount, and the rule does not apply to it.One limit stays for a bundle with one call. If the wallet sends it and then loses its record of it within 10 minutes of signing, "Try again" can sign a second bundle. Examples are "Delete activity and nonce data" or "Reset account" in MetaMask, or a remote status service that forgets the bundle.
When the wallet has no record of the bundle at its first answer, the step fails with the new code
LiFiErrorCode.CallBundleNotFound. A page reload after the reject is an example. The step also fails with this code when the rule does not apply. An example is a wallet that loses the bundle 10 minutes or more after signing. The SDK cannot know if the wallet sent this bundle. Thus the action keeps the bundle id, and "Try again" waits for the bundle again and does not sign. A route that is stuck after a reject on@lifi/sdk4.11.0 fails withCallBundleNotFoundon its next "Try again".If an "unknown bundle id" error (5730) reaches the error parser from another call, the step also fails with
CallBundleNotFound, not withSignatureRejected.Updated dependencies [
5dc9cc5]:@lifi/sdk-provider-solana@4.3.5
Patch Changes
5dc9cc5]:@lifi/sdk-provider-stellar@4.3.9
Patch Changes
5dc9cc5]:@lifi/sdk-provider-sui@4.2.9
Patch Changes
5dc9cc5]:@lifi/sdk-provider-tron@4.1.8
Patch Changes
5dc9cc5]:@lifi/sdk-provider-zcash@4.0.1
Patch Changes
5dc9cc5]: