Skip to content

Include failure context in splice events #4514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 11 commits into from
May 7, 2026

Derive DiscardFunding inputs and outputs from contributions on promotion

51e6079
Select commit
Loading
Failed to load commit list.
Merged

Include failure context in splice events #4514

Derive DiscardFunding inputs and outputs from contributions on promotion
51e6079
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 0s

86.10% (-0.07%) compared to 1d36f7b

View this Pull Request on Codecov

86.10% (-0.07%) compared to 1d36f7b

Details

Codecov Report

❌ Patch coverage is 87.05882% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.10%. Comparing base (1d36f7b) to head (51e6079).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/events/mod.rs 25.00% 18 Missing ⚠️
lightning/src/ln/channelmanager.rs 90.98% 5 Missing and 6 partials ⚠️
lightning/src/ln/channel.rs 96.93% 2 Missing and 1 partial ⚠️
lightning/src/ln/functional_test_utils.rs 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4514      +/-   ##
==========================================
- Coverage   86.16%   86.10%   -0.07%     
==========================================
  Files         156      157       +1     
  Lines      108669   108766      +97     
  Branches   108669   108766      +97     
==========================================
+ Hits        93638    93652      +14     
- Misses      12420    12495      +75     
- Partials     2611     2619       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov