Skip to content

Default to requiring `payment_metadata` when building BOLT 11s

44828f7
Select commit
Loading
Failed to load commit list.
Merged

Commit to payment_metadata in inbound payment HMAC #4528

Default to requiring `payment_metadata` when building BOLT 11s
44828f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2026 in 0s

86.12% (+0.01%) compared to 946ee09

View this Pull Request on Codecov

86.12% (+0.01%) compared to 946ee09

Details

Codecov Report

❌ Patch coverage is 94.26230% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.12%. Comparing base (946ee09) to head (44828f7).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/inbound_payment.rs 95.23% 4 Missing ⚠️
lightning/src/ln/channelmanager.rs 87.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4528      +/-   ##
==========================================
+ Coverage   86.11%   86.12%   +0.01%     
==========================================
  Files         157      157              
  Lines      108841   108922      +81     
  Branches   108841   108922      +81     
==========================================
+ Hits        93725    93812      +87     
+ Misses      12497    12495       -2     
+ Partials     2619     2615       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.