Skip to content

Resolve outbound HTLC fails via MonitorEvents #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
valentinewallace wants to merge 41 commits into
base: main
Choose a base branch
from

Persistent monitor events for onchain outbound fails

b03e434
Select commit
Loading
Failed to load commit list.
Draft

Resolve outbound HTLC fails via MonitorEvents #4604

Persistent monitor events for onchain outbound fails
b03e434
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 20, 2026 in 0s

86.64% (+58.62%) compared to ee456a8

View this Pull Request on Codecov

86.64% (+58.62%) compared to ee456a8

Details

Codecov Report

❌ Patch coverage is 91.44444% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.64%. Comparing base (ee456a8) to head (b03e434).

Files with missing lines Patch % Lines
lightning/src/chain/channelmonitor.rs 91.43% 21 Missing and 10 partials ⚠️
lightning/src/ln/channelmanager.rs 92.78% 23 Missing and 5 partials ⚠️
lightning/src/ln/functional_test_utils.rs 64.51% 11 Missing ⚠️
lightning/src/ln/channel.rs 93.10% 4 Missing ⚠️
lightning/src/events/mod.rs 33.33% 2 Missing ⚠️
lightning/src/chain/chainmonitor.rs 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4604       +/-   ##
===========================================
+ Coverage   28.02%   86.64%   +58.62%     
===========================================
  Files         126      159       +33     
  Lines       69960   111098    +41138     
  Branches    69960   111098    +41138     
===========================================
+ Hits        19606    96263    +76657     
+ Misses      49020    12290    -36730     
- Partials     1334     2545     +1211

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov