Skip to content

Encrypt payment_metadata when we build the payment secret #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
May 22, 2026

Unify and simplify the application of simple chacha20 passes

4fac0fe
Select commit
Loading
Failed to load commit list.
Merged

Encrypt payment_metadata when we build the payment secret #4628

Unify and simplify the application of simple chacha20 passes
4fac0fe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 22, 2026 in 1s

86.69% (+0.10%) compared to 1743b99

View this Pull Request on Codecov

86.69% (+0.10%) compared to 1743b99

Details

Codecov Report

❌ Patch coverage is 91.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.69%. Comparing base (1743b99) to head (4fac0fe).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/inbound_payment.rs 91.22% 5 Missing ⚠️
lightning/src/ln/channelmanager.rs 83.33% 2 Missing ⚠️
lightning/src/ln/invoice_utils.rs 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4628      +/-   ##
==========================================
+ Coverage   86.58%   86.69%   +0.10%     
==========================================
  Files         159      159              
  Lines      110498   110604     +106     
  Branches   110498   110604     +106     
==========================================
+ Hits        95678    95888     +210     
+ Misses      12281    12198      -83     
+ Partials     2539     2518      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov