build(ci): add --base/--head changed-files support to validate-frontmatter by Copilot · Pull Request #2499 · lightspeedwp/.github

Copilot · 2026-08-29T15:21:36Z

The front-matter-validate CI check was failing on every PR because npm run validate:frontmatter:changed existed in package.json but the underlying script ignored the --base/--head SHA flags passed by the workflow — effectively running a full scan on every invocation and providing no "changed files only" behaviour.

Build/CI change

FileDiscovery.findChangedFiles(baseSha, headSha, ...) — new static method; runs git diff --name-only --diff-filter=ACMRT via execFileSync (arg array, no shell) and intersects results with the pattern-matched/excluded file set; falls back to full scan gracefully on any git error
SHA validation — rejects non-hex or out-of-range values before exec, eliminating the shell-injection vector CodeQL flagged
validateFrontmatter(filePaths?) — accepts an optional file list; CLI wires it up when both --base and --head are present, full scan otherwise
Promise rejection safety — both validateFrontmatter() call sites now chain .catch() so async rejections produce a non-zero exit rather than a silent pass

# CI invocation now resolves correctly
npm run validate:frontmatter:changed -- --base $BASE_SHA --head $HEAD_SHA
# → validates only .md/.yml files touched in the PR diff

Baseline & Target

Before: CI step always ran full repo scan (~500+ files); no SHA-scoped filtering despite the flag being passed
After: Only files changed between BASE_SHA and HEAD_SHA are validated; full fallback retained when git is unavailable

Rollback

Revert the single commit to scripts/validation/validate-frontmatter.js; the validate:frontmatter:changed npm script entry in package.json is unchanged.

Notes

Uses execFileSync (argument array) — no shell involved, no injection surface
SHA regex: /^[0-9a-f]{4,64}$/i — covers abbreviated and full SHAs

Changelog

Fixed

validate:frontmatter:changed now correctly scopes validation to files changed between the two git SHAs supplied by the CI workflow, unblocking the front-matter-validate check on every PR. (Closes fix: Missing npm script 'validate:frontmatter:changed' in CI workflow #1929)

Checklist (Global DoD / PR)

Fixes fix: Missing npm script 'validate:frontmatter:changed' in CI workflow #1929

The CI workflow calls `npm run validate:frontmatter:changed -- --base $BASE_SHA --head $HEAD_SHA` but the script previously ignored those flags and validated all files. This change: - Adds `FileDiscovery.findChangedFiles(baseSha, headSha, ...)` which uses `git diff --name-only --diff-filter=ACMRT` (via execFileSync, no shell interpolation) to get changed files, then intersects with the set of pattern-matched/non-excluded files; falls back to full scan on any error. - Validates SHA format (4–64 hex chars) before use to prevent shell injection. - Updates `validateFrontmatter(filePaths?)` to accept an optional file list. - Parses `--base`/`--head` in the CLI and passes the changed-file list to the validator when both are present. - Chains `.catch()` on both `validateFrontmatter()` call sites so unhandled rejections cause a non-zero exit (CI correctness fix). - Updates `--help` output to document the new flags. Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>

…rontmatter-change

Copilot

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR fixes the validate:frontmatter:changed CI workflow path by adding --base/--head support so frontmatter validation can scope to only files changed between two git SHAs, while retaining a full-scan fallback.

Changes:

Added FileDiscovery.findChangedFiles(baseSha, headSha, ...) to compute changed files via git diff --name-only and filter them to supported patterns/exclusions.
Updated validateFrontmatter(filePaths?) and CLI arg parsing to validate only changed files when --base and --head are provided.
Ensured async validation invocations surface failures via .catch() with non-zero exit codes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Shaw <ashley@lightspeedwp.agency>

github-actions · 2026-08-29T17:02:10Z

🔍 Reviewer Summary for PR #2499

CI Status: ❌ pending
Files changed: 1

Recommendations

CI checks not green

github-actions · 2026-08-29T17:03:18Z

🔍 Reviewer Summary for PR #2499

CI Status: ❌ pending
Files changed: 1

Recommendations

CI checks not green

…e CI diagnostics Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>

ashleyshaw · 2026-08-29T17:15:52Z

github-actions · 2026-08-29T17:26:50Z

🔍 Reviewer Summary for PR #2499

CI Status: ❌ pending
Files changed: 2

Recommendations

CI checks not green

github-actions · 2026-08-29T17:28:13Z

🔍 Reviewer Summary for PR #2499

CI Status: ❌ pending
Files changed: 2

Recommendations

CI checks not green

github-actions · 2026-08-29T17:31:52Z

🚫 This PR description is missing required template content.

Missing required section(s): Linked issues, Global DoD checklist

Please update the PR body using one of the repository PR templates:

Empty placeholders, unchecked checklist boxes, and stub issue references do not count.

github-actions · 2026-08-30T08:09:45Z

⚠️ Branch Naming Issue

This PR's branch name copilot/fix-missing-npm-script-validate-frontmatter-change doesn't follow the standard pattern.

Standard pattern: {type}/{scope}-{title} (e.g., feat/something, fix/bug-name)

Based on linked issue type: bug

Correct template should be: pr_bug.md

No action required — this is informational. Future PRs should use the correct branch name.

See Branching Strategy for more info.

github-actions · 2026-08-30T08:10:23Z

🔍 Reviewer Summary for PR #2499

CI Status: ❌ pending
Files changed: 2

Recommendations

CI checks not green

github-actions · 2026-08-30T15:44:41Z

🔍 Reviewer Summary for PR #2499

CI Status: ❌ pending
Files changed: 2

Recommendations

CI checks not green

The CI workflow calls `npm run validate:frontmatter:changed -- --base $BASE_SHA --head $HEAD_SHA` but the script previously ignored those flags and validated all files. This change: - Adds `FileDiscovery.findChangedFiles(baseSha, headSha, ...)` which uses `git diff --name-only --diff-filter=ACMRT` (via execFileSync, no shell interpolation) to get changed files, then intersects with the set of pattern-matched/non-excluded files; falls back to full scan on any error. - Validates SHA format (4–64 hex chars) before use to prevent shell injection. - Updates `validateFrontmatter(filePaths?)` to accept an optional file list. - Parses `--base`/`--head` in the CLI and passes the changed-file list to the validator when both are present. - Chains `.catch()` on both `validateFrontmatter()` call sites so unhandled rejections cause a non-zero exit (CI correctness fix). - Updates `--help` output to document the new flags. Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Shaw <ashley@lightspeedwp.agency>

…e CI diagnostics Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>

github-actions · 2026-09-01T17:58:33Z

❌ Branch Name Validation Failed

The branch name copilot/fix-missing-npm-script-validate-frontmatter-change does not follow the LightSpeed branching strategy.

Required Format

{type}/{scope}-{short-title}

type: one of the allowed prefixes (lowercase)
scope: lowercase, hyphens only (no underscores or uppercase)
title: lowercase, hyphens only (no underscores or uppercase)

Allowed Branch Types

feat, fix, hotfix, release, refactor, chore, docs, test, perf, ci, build, deps, security, revert, research, design, a11y, ux, i18n, ops, proto, ds, api, schema, telemetry, content, seo, config, migrate, qa, uat, audit, codex

Valid Examples

✓ feat/branch-naming-enforcement
✓ fix/validation-script-bug
✓ chore/update-dependencies
✓ docs/branching-strategy-guide
✓ hotfix/critical-security-patch

Invalid Examples

✗ claude/my-branch (type "claude" not allowed)
✗ Feature/MyBranch (uppercase not allowed)
✗ fix-bug (missing type prefix)
✗ feat/my_feature (underscores not allowed)
✗ feat/MyFeature (uppercase not allowed)

Solution

Rename your branch to follow the pattern and update the PR.

For more information, see docs/BRANCHING_STRATEGY.md.

…rontmatter-change

Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>

…nge' of https://github.com/lightspeedwp/.github into ci/fix-missing-npm-script-validate-frontmatter-change

Initial plan

9abb726

Copilot AI assigned Copilot and ashleyshaw Aug 29, 2026

Copilot started work on behalf of ashleyshaw August 29, 2026 15:25 View session

Copilot AI linked an issue Aug 29, 2026 that may be closed by this pull request

fix: Missing npm script 'validate:frontmatter:changed' in CI workflow #1929

Open

Copilot AI changed the title ~~[WIP] Fix missing npm script 'validate:frontmatter:changed' in CI workflow~~ build(ci): add --base/--head changed-files support to validate-frontmatter Aug 29, 2026

Copilot finished work on behalf of ashleyshaw August 29, 2026 15:34

Copilot AI requested a review from ashleyshaw August 29, 2026 15:34

ashleyshaw marked this pull request as ready for review August 29, 2026 16:33

Merge branch 'develop' into copilot/fix-missing-npm-script-validate-f…

d69b5fe

…rontmatter-change

ashleyshaw requested a lite review from Copilot August 29, 2026 16:39

ashleyshaw enabled auto-merge (squash) August 29, 2026 16:41

Copilot AI reviewed Aug 29, 2026

View reviewed changes

Comment thread scripts/validation/validate-frontmatter.js Outdated

Comment thread scripts/validation/validate-frontmatter.js Outdated

Comment thread scripts/validation/validate-frontmatter.js

Comment thread scripts/validation/validate-frontmatter.js Outdated

Copilot started work on behalf of ashleyshaw August 29, 2026 17:01 View session

Potential fix for pull request finding

c6ccb50

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Shaw <ashley@lightspeedwp.agency>

perf: filter changed paths with minimatch instead of full findFiles scan

bbfff87

auto-merge was automatically disabled August 29, 2026 17:04
Head branch was pushed to by a user without write access

Copilot started work on behalf of ashleyshaw August 29, 2026 17:04 View session

Copilot started work on behalf of ashleyshaw August 29, 2026 17:05 View session

fix: log err?.stack ?? String(err) in .catch() handlers for actionabl…

f72e944

…e CI diagnostics Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>

Copilot started reviewing on behalf of ashleyshaw August 29, 2026 17:06 View session

Copilot started work on behalf of ashleyshaw August 29, 2026 17:07 View session

ashleyshaw enabled auto-merge (squash) August 29, 2026 17:07

Copilot finished work on behalf of ashleyshaw August 29, 2026 17:07

Copilot finished work on behalf of ashleyshaw August 29, 2026 17:08

Copilot finished work on behalf of ashleyshaw August 29, 2026 17:12

ashleyshaw added this to the v1.1 milestone Aug 30, 2026

Copilot AI and others added 5 commits September 2, 2026 00:55

Initial plan

8bf43b4

Potential fix for pull request finding

e31d3dc

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Shaw <ashley@lightspeedwp.agency>

perf: filter changed paths with minimatch instead of full findFiles scan

e1d9115

fix: log err?.stack ?? String(err) in .catch() handlers for actionabl…

6ed087d

…e CI diagnostics Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>

ashleyshaw force-pushed the copilot/fix-missing-npm-script-validate-frontmatter-change branch from caeb4cf to 6ed087d Compare September 1, 2026 17:56

Merge branch 'develop' into copilot/fix-missing-npm-script-validate-f…

4de0ed1

…rontmatter-change

Copilot started work on behalf of ashleyshaw September 2, 2026 17:01 View session

fix: normalize CRLF git diff paths in frontmatter validation

cc8f3dc

Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>

auto-merge was automatically disabled September 2, 2026 17:03
Head branch was pushed to by a user without write access

Copilot finished work on behalf of ashleyshaw September 2, 2026 17:08

ashleyshaw enabled auto-merge September 2, 2026 18:44

Merge branch 'copilot/fix-missing-npm-script-validate-frontmatter-cha…

6b897c3

…nge' of https://github.com/lightspeedwp/.github into ci/fix-missing-npm-script-validate-frontmatter-change

claude Bot added area:ci Build and CI pipelines area:scripts Scripts & tooling area:tests Test suites & harnesses lang:js JavaScript/TypeScript lang:json JSON config/content type:bug Bug or defect labels Sep 2, 2026

Navigation Menu

Uh oh!

build(ci): add --base/--head changed-files support to validate-frontmatter - #2499

build(ci): add --base/--head changed-files support to validate-frontmatter#2499
ashleyshaw with Copilot wants to merge 14 commits into
developfrom
copilot/fix-missing-npm-script-validate-frontmatter-change

Copilot AI commented Aug 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 29, 2026

Uh oh!

github-actions Bot commented Aug 29, 2026

Uh oh!

ashleyshaw commented Aug 29, 2026

Uh oh!

github-actions Bot commented Aug 29, 2026

Uh oh!

github-actions Bot commented Aug 29, 2026

Uh oh!

github-actions Bot commented Aug 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

github-actions Bot commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build/CI change

Baseline & Target

Rollback

Notes

Changelog

Fixed

Checklist (Global DoD / PR)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 29, 2026

🔍 Reviewer Summary for PR #2499

Recommendations

Uh oh!

github-actions Bot commented Aug 29, 2026

🔍 Reviewer Summary for PR #2499

Recommendations

Uh oh!

ashleyshaw commented Aug 29, 2026

Merge readiness checklist for #2499 (develop)

Summary

1) Fix in this PR (must complete before merge)

2) Track in separate issue (do not block this PR if unrelated)

3) Final approval + merge steps

Post-merge quick verification (develop)

Uh oh!

github-actions Bot commented Aug 29, 2026

🔍 Reviewer Summary for PR #2499

Recommendations

Uh oh!

github-actions Bot commented Aug 29, 2026

🔍 Reviewer Summary for PR #2499

Recommendations

Uh oh!

github-actions Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2499

Recommendations

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2499

Recommendations

Uh oh!

github-actions Bot commented Sep 1, 2026

❌ Branch Name Validation Failed

Required Format

Allowed Branch Types

Valid Examples

Invalid Examples

Solution

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Aug 29, 2026 •

edited

Loading

Merge readiness checklist for #2499 (`develop`)

github-actions Bot commented Aug 29, 2026 •

edited

Loading