chore(ci): delete issue-create-from-template.yml (superseded by issue-create-enhanced.yml) - #2510
Conversation
…-create-enhanced.yml, #1377) Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The updated contract test targets issue-create-enhanced.yml, which currently references a missing 08-task.md template, and there remain widespread references/badges to the deleted legacy workflow in repo docs/skills that will become broken.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes the legacy issue-create-from-template.yml workflow as part of the workflow consolidation effort, and updates a small number of references/tests/schema entries to point at the newer issue-create-enhanced.yml.
Changes:
- Deleted
.github/workflows/issue-create-from-template.yml(legacy workflow). - Updated the issue-template contract test to validate
issue-create-enhanced.yml. - Updated the template-enforcement workflow’s guidance text and removed the legacy workflow from the badges schema/group list.
File summaries
| File | Description |
|---|---|
scripts/validation/__tests__/issue-template-contract.test.js |
Points the contract test at issue-create-enhanced.yml instead of the deleted legacy workflow. |
.github/workflows/template-enforcement.yml |
Updates the recommended workflow reference in the enforcement comment body. |
.github/workflows/issue-create-from-template.yml |
Deletes the superseded workflow. |
.github/automation/badges.schema.yml |
Removes the deleted workflow from badge definitions and the automation workflow group list. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| it("references existing template files in the issue creation workflow", () => { | ||
| const workflowPath = path.join( | ||
| __dirname, | ||
| "../../../.github/workflows/issue-create-from-template.yml", | ||
| "../../../.github/workflows/issue-create-enhanced.yml", | ||
| ); |
There was a problem hiding this comment.
Fixed in the latest commit — updated issue-create-enhanced.yml to reference .github/ISSUE_TEMPLATE/01-task.md instead of the non-existent 08-task.md.
There was a problem hiding this comment.
Updated in 207c01c: the enhanced workflow now points at the valid task template and validates canonical type compatibility before creating the issue.
| automation: | ||
| label: "Automation" | ||
| description: "Automated workflow and issue management" | ||
| workflows: | ||
| - badges-documentation-update | ||
| - badges-health-check | ||
| - badges-readme-status | ||
| - badges-workflow-audit | ||
| - issue-create-enhanced | ||
| - issue-create-from-template | ||
| - issue-labeling-automation | ||
| - issue-project-field-sync | ||
| - labeling |
There was a problem hiding this comment.
Done. Removed the issue-create-from-template.yml badge from 580 docs/ and skills/ files (which already had the issue-create-enhanced badge), and updated the table entry in docs/WORKFLOW_COORDINATION.md to reference issue-create-enhanced.yml.
There was a problem hiding this comment.
Updated in 207c01c: the stale issue-create-from-template badge references were replaced with issue-create-enhanced across the repo so the deleted workflow no longer leaves broken links behind.
…-enhanced Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>
Head branch was pushed to by a user without write access
Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>
Head branch was pushed to by a user without write access
🔍 Reviewer Summary for PR #2510CI Status: ❌ Recommendations
|
🔍 Reviewer Summary for PR #2510CI Status: ❌ Recommendations
|
|
Missing required section(s): Linked issues This is a post-merge backstop for admin bypasses. Please review branch protection for develop. |
📄 README Validation❌ One or more README checks failed.
|
…ithub.com/lightspeedwp/.github into chore/delete-issue-create-from-template
claude
Bot
added
area:ci
🔍 Reviewer Summary for PR #2510CI Status: ❌ Recommendations
|
🎨 Mermaid Diagram Validation❌ One or more Mermaid diagram checks failed.
|
Head branch was pushed to by a user without write access
Fixed: the numbered issue templates now use GitHub’s |
🔍 Reviewer Summary for PR #2510CI Status: ❌ Recommendations
|
|
@Mergifyio queue |
Merge Queue Status
Waiting for
All conditions
|
…ue-create-from-template
🔍 Reviewer Summary for PR #2510CI Status: ❌ Recommendations
|
|
✅ PR checklists finalised after merge. |
issue-create-from-template.ymlis fully superseded byissue-create-enhanced.yml(#1377), which covers the sametemplate_keyinputs plus adds extra parameters and improved error handling. Part of the Workflows Consolidation Initiative (#1227). Net: −1 workflow.Changes
.github/workflows/issue-create-from-template.ymlscripts/validation/__tests__/issue-template-contract.test.js— contract test now validatesissue-create-enhanced.yml.github/workflows/template-enforcement.yml— recommended workflow reference in enforcement comment body updated.github/automation/badges.schema.yml— removedissue-create-from-templateentry from schema definition and automation group workflow listImpact / Compatibility
issue-create-enhanced.ymlalready handles all use casesissue-create-enhanced.ymlVerification
Risk & Rollback
Changelog
Removed
issue-create-from-template.ymlworkflow (superseded byissue-create-enhanced.yml, relates to feat: implement comprehensive issue triage automation system #1377)Checklist (Global DoD / PR)