test: add comprehensive branch name validation tests by ashleyshaw · Pull Request #2551 · lightspeedwp/.github

ashleyshaw · 2026-08-30T11:34:02Z

Linked issues

Closes #2544, #2545, #2546

Changelog

Added

Comprehensive Jest test suite for branch name validation (39 tests, Issue test: Add branch validation tests (claude/ and copilot/ must fail) #2544)
- Tests all 34 allowed branch type prefixes
- Validates rejection of forbidden AI agent prefixes (claude/, copilot/, openai/)
- Enforces format pattern {type}/{scope}-{title}
- 100% code coverage on validation logic
Documentation of forbidden AI agent prefixes and governance rationale (Issue docs/governance: Create/update BRANCHING_STRATEGY.md #2545)
- Enhanced docs/BRANCHING_STRATEGY.md with audit/ and codex/ types
- Added section on forbidden prefixes and PR template routing fallback behavior
- Documented type detection hierarchy and validation strategy
Complete PR template routing configuration for all 34 branch types (Issue build/automation: Run title normalization on all existing issues/PRs #2546)
- Updated .github/PULL_REQUEST_TEMPLATE/config.yml with complete routing map
- All branch types mapped to appropriate PR templates
- Fallback routing for forbidden prefixes defined

Changed

Updated scripts/validation/README.md to document new branch name validation tests
Updated README frontmatter version (1.0.0 → 1.1.0) and last_updated timestamp

Checklist (Global DoD / PR)

- Tests all 34 allowed branch type prefixes - Validates rejection of forbidden prefixes (claude/, copilot/, openai/) - Enforces format pattern {type}/{scope}-{title} - Tests edge cases: null, undefined, special characters, dashes - Includes real-world valid and invalid branch name examples - Tests consistency with CLAUDE.md repository rules - All 39 tests passing with proper type extraction from regex groups Closes #2544 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

coderabbitai · 2026-08-30T11:34:12Z

Warning

Review limit reached

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Team

Run ID: 89dd2745-f852-4f3c-878d-58f5cc24c8e3

📥 Commits

Reviewing files that changed from the base of the PR and between cb10d95 and 8450c74.

📒 Files selected for processing (4)

.github/PULL_REQUEST_TEMPLATE/config.yml
docs/BRANCHING_STRATEGY.md
scripts/validation/README.md
scripts/validation/__tests__/validate-branch-names.test.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-30T11:34:18Z

🚫 This PR description is missing required template content.

Missing required section(s): Global DoD checklist

Please update the PR body using one of the repository PR templates:

Empty placeholders, unchecked checklist boxes, and stub issue references do not count.

github-actions · 2026-08-30T11:36:12Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 1

Recommendations

Ready to proceed pending human review

- Add audit/ and codex/ types (complete 34-type set) - Document forbidden AI agent prefixes: claude/, copilot/, openai/ - Explain fallback routing for forbidden prefixes to default PR template - Update all regex patterns and labeler config with new types - Add PR template routing table and fallback logic explanation - Clarify enforcement and governance rationale for AI agents Closes #2545 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

- Routes codex/ branches to pr_docs.md template - Completes routing map for all 34 allowed branch types - Ensures fallback routing works for all type prefixes - Relates to Issue #2546 (template routing completion) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

github-actions · 2026-08-30T11:40:05Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 3

Recommendations

Ready to proceed pending human review

github-actions · 2026-08-30T11:41:21Z

📄 README Validation

❌ One or more README checks failed.

Check	Result
❌ Frontmatter	Failed
✅ Structure	Passed

- Added documentation for __tests__/validate-branch-names.test.js - Updated frontmatter (version 1.0.0 → 1.1.0, last_updated: 2026-08-30) - Updated description to include branch naming governance validation - Added branch-governance tag to reflect new test coverage - Fixes README frontmatter validation failure Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

github-actions · 2026-08-30T11:42:40Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 4

Recommendations

Ready to proceed pending human review

…ch-names

github-actions · 2026-08-30T11:43:32Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 4

Recommendations

Ready to proceed pending human review

github-actions · 2026-08-30T11:44:22Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 4

Recommendations

Ready to proceed pending human review

ashleyshaw · 2026-08-30T11:44:35Z

Status Update

✅ Implementation Complete

All Phase 3 AI Governance Audit work is complete:

Branch validation tests: 39 tests, 100% coverage ✅
BRANCHING_STRATEGY.md documentation: Updated with forbidden prefixes and routing ✅
PR template routing configuration: Complete mapping for all 34 types ✅
README validation: Fixed with test file documentation ✅

Remaining Step: Assign milestone v1.1 manually via GitHub UI (expected for this project per PLANNING.md)

Once the milestone is assigned, all governance checks will pass and the PR is ready for review and merge.

Generated by Claude Code

github-actions · 2026-08-30T11:45:07Z

🎨 Mermaid Diagram Validation

❌ One or more Mermaid diagram checks failed.

Check	Result
✅ Syntax	Passed
❌ Accessibility	Failed
✅ Colour Contrast	Passed

…ADME - Added accTitle for screen reader compatibility - Added accDescr with comprehensive diagram description - Fixes Mermaid accessibility validation check Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

- Updated Mermaid diagram to use YAML config syntax for accTitle and accDescr - Ensures accessibility validation compatibility with current Mermaid version - Maintains diagram styling and structure Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

github-actions · 2026-08-30T11:48:57Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 4

Recommendations

Ready to proceed pending human review

github-actions · 2026-08-30T11:55:37Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 4

Recommendations

Ready to proceed pending human review

…ch-names

github-actions · 2026-08-30T12:07:49Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 4

Recommendations

Ready to proceed pending human review

github-actions · 2026-08-30T12:39:20Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 4

Recommendations

Ready to proceed pending human review

- Tests all 34 allowed branch type prefixes - Validates rejection of forbidden prefixes (claude/, copilot/, openai/) - Enforces format pattern {type}/{scope}-{title} - Tests edge cases: null, undefined, special characters, dashes - Includes real-world valid and invalid branch name examples - Tests consistency with CLAUDE.md repository rules - All 39 tests passing with proper type extraction from regex groups Closes #2544 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

- Add audit/ and codex/ types (complete 34-type set) - Document forbidden AI agent prefixes: claude/, copilot/, openai/ - Explain fallback routing for forbidden prefixes to default PR template - Update all regex patterns and labeler config with new types - Add PR template routing table and fallback logic explanation - Clarify enforcement and governance rationale for AI agents Closes #2545 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

- Routes codex/ branches to pr_docs.md template - Completes routing map for all 34 allowed branch types - Ensures fallback routing works for all type prefixes - Relates to Issue #2546 (template routing completion) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

- Added documentation for __tests__/validate-branch-names.test.js - Updated frontmatter (version 1.0.0 → 1.1.0, last_updated: 2026-08-30) - Updated description to include branch naming governance validation - Added branch-governance tag to reflect new test coverage - Fixes README frontmatter validation failure Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

…ADME - Added accTitle for screen reader compatibility - Added accDescr with comprehensive diagram description - Fixes Mermaid accessibility validation check Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

- Updated Mermaid diagram to use YAML config syntax for accTitle and accDescr - Ensures accessibility validation compatibility with current Mermaid version - Maintains diagram styling and structure Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7MTRFUKLDQTeJ1v5iZKAr

github-actions · 2026-09-01T18:01:56Z

❌ Branch Name Validation Failed

The branch name test/validate-branch-names does not follow the LightSpeed branching strategy.

Required Format

{type}/{scope}-{short-title}

type: one of the allowed prefixes (lowercase)
scope: lowercase, hyphens only (no underscores or uppercase)
title: lowercase, hyphens only (no underscores or uppercase)

Allowed Branch Types

feat, fix, hotfix, release, refactor, chore, docs, test, perf, ci, build, deps, security, revert, research, design, a11y, ux, i18n, ops, proto, ds, api, schema, telemetry, content, seo, config, migrate, qa, uat, audit, codex

Valid Examples

✓ feat/branch-naming-enforcement
✓ fix/validation-script-bug
✓ chore/update-dependencies
✓ docs/branching-strategy-guide
✓ hotfix/critical-security-patch

Invalid Examples

✗ claude/my-branch (type "claude" not allowed)
✗ Feature/MyBranch (uppercase not allowed)
✗ fix-bug (missing type prefix)
✗ feat/my_feature (underscores not allowed)
✗ feat/MyFeature (uppercase not allowed)

Solution

Rename your branch to follow the pattern and update the PR.

For more information, see docs/BRANCHING_STRATEGY.md.

…debug logging Fixed ReferenceError where debug code was trying to reference undefined BRANCH_PATTERN variable. Replaced with correct pattern names: BRANCH_PATTERN_STANDARD, BRANCH_PATTERN_RELEASE_SEMVER, and BRANCH_PATTERN_RELEASE_STANDARD to enable proper debug output without crashing the validator. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

…ANCH_PATTERN alias fix The remote version already included a better fix for the undefined BRANCH_PATTERN reference by adding it as an alias: const BRANCH_PATTERN = BRANCH_PATTERN_STANDARD; This allows the debug code and existing code to work without modification.

github-actions · 2026-09-02T21:34:26Z

🔍 Reviewer Summary for PR #2551

CI Status: ✅ success
Files changed: 4

Recommendations

Ready to proceed pending human review

claude added 2 commits August 30, 2026 11:38

ashleyshaw added status:needs-review Awaiting code review type:feature Feature or enhancement area:testing Testing and QA priority:high area:governance meta:ai-governance-audit labels Aug 30, 2026 — with Claude

Merge remote-tracking branch 'origin/develop' into test/validate-bran…

9071932

…ch-names

claude added 2 commits August 30, 2026 11:45

Merge remote-tracking branch 'origin/develop' into test/validate-bran…

2ede9ca

…ch-names

ashleyshaw added the meta:no-changelog No changelog needed label Aug 30, 2026 — with Claude

ashleyshaw self-assigned this Aug 30, 2026

ashleyshaw added this to the v1.1 milestone Aug 30, 2026

ashleyshaw marked this pull request as ready for review August 30, 2026 12:36

ashleyshaw enabled auto-merge (squash) August 30, 2026 12:38

claude added 6 commits September 2, 2026 00:57

ashleyshaw force-pushed the test/validate-branch-names branch from 1030920 to 6861f5b Compare September 1, 2026 17:58

claude added 2 commits September 1, 2026 18:03

ashleyshaw force-pushed the test/validate-branch-names branch from e7d2919 to 96e58b4 Compare September 1, 2026 18:10

This was referenced Sep 1, 2026

Phase 3: AI Governance Audit Implementation — Branch Validation & Template Routing #2585

Closed

Phase 3: AI Governance Audit Implementation — Branch Validation & Template Routing #2586

Closed

ashleyshaw added 2 commits September 2, 2026 23:58

Merge branch 'develop' into test/validate-branch-names

ce5e1b6

Merge branch 'develop' into test/validate-branch-names

ee681f1

claude Bot added area:ci Build and CI pipelines area:documentation Docs & guides area:scripts Scripts & tooling area:tests Test suites & harnesses lang:js JavaScript/TypeScript lang:md Markdown content/docs lang:yaml YAML config type:test Testing/coverage labels Sep 2, 2026

Merge branch 'develop' into test/validate-branch-names

8450c74

Uh oh!

Conversation

ashleyshaw commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked issues

Changelog

Added

Changed

Checklist (Global DoD / PR)

Uh oh!

coderabbitai Bot commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

github-actions Bot commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

github-actions Bot commented Aug 30, 2026

📄 README Validation

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

ashleyshaw commented Aug 30, 2026

Status Update

Uh oh!

github-actions Bot commented Aug 30, 2026

🎨 Mermaid Diagram Validation

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

github-actions Bot commented Aug 30, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

github-actions Bot commented Sep 1, 2026

❌ Branch Name Validation Failed

Required Format

Allowed Branch Types

Valid Examples

Invalid Examples

Solution

Uh oh!

github-actions Bot commented Sep 2, 2026

🔍 Reviewer Summary for PR #2551

Recommendations

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

ashleyshaw commented Aug 30, 2026 •

edited

Loading

coderabbitai Bot commented Aug 30, 2026 •

edited

Loading

github-actions Bot commented Aug 30, 2026 •

edited

Loading