fix: show hdc devices when one target fails to parse - #30
Open
tonycoder-hub wants to merge 2 commits into
Open
Conversation
getTargets used Promise.all().catch(() => []), so any getParameters or version-parse error wiped the entire device list. Isolate failures per target and parse software version defensively. Fixes liriliri#21 Signed-off-by: Tony Coder <407243179@qq.com>
Use an explicit .ts import and drop the types-path alias so npm test runs without a device or extra test runner. Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21
getTargets used Promise.all().catch(() => []), so any getParameters or version-parse error wiped the entire device list. Isolate failures per target and parse software version defensively.
No-device unit tests.
Signed-off-by: Tony Coder 407243179@qq.com