Fix segfault: Add mandatory 'location' validation in validator and reader#65
Open
MutableFire wants to merge 2 commits into
Open
Fix segfault: Add mandatory 'location' validation in validator and reader#65MutableFire wants to merge 2 commits into
MutableFire wants to merge 2 commits into
Conversation
MutableFire
force-pushed
the
fix-missing-location
branch
6 times, most recently
from
ae57f3c to
027c2ac
Compare
MutableFire
force-pushed
the
fix-missing-location
branch
2 times, most recently
from
7374be7 to
689cc08
Compare
…ssing-location
MutableFire
force-pushed
the
fix-missing-location
branch
from
689cc08 to
a5fb735
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix segmentation fault by implementing strict validation for the mandatory
locationoption in both the FDW validator and the internal location reader. Instead of crashing when the option is missing, the invalid table creation is rejected now. When this table has already been created, throw an error on access.