Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci(deploy-examples): include avatar deployment #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci(deploy-examples): include avatar deployment #1599
Changes from all commits
b95cb4cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning
Code scanning / CodeQL
Excessive Secrets Exposure Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 OPENAI_API_KEY pulled into env but never written to secrets file for any example
The
Build secrets filestep mapsOPENAI_API_KEYfrom GitHub secrets into the shell environment (line 93), but thecasestatement (lines 100-107) never adds it to.env.deployfor any example — the wildcard*)branch setskeys="". Thefrontdeskanddrive-thruexamples directly instantiatenew openai.LLM(...)(examples/src/frontdesk/frontdesk_agent.ts:225andexamples/src/drive-thru/drivethru_agent.ts:389), which readsOPENAI_API_KEYfrom the environment at runtime. Unless this key is separately configured at the LiveKit Cloud project level, those deployed agents will fail when attempting OpenAI API calls. At minimum,OPENAI_API_KEYinenv:is dead code if intentionally managed elsewhere, or a missingcaseentry if it was intended to be passed through the secrets file.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.