-
Notifications
You must be signed in to change notification settings - Fork 295
fix(google): handle content blocking and generation failures #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rosetta-livekit-bot
wants to merge
4
commits into
main
Choose a base branch
from
fix-google-generation-failures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dd61d9d
fix(google): surface generation failures
rosetta-livekit-bot[bot] 1dae911
fix(google): use SDK finish reasons
rosetta-livekit-bot[bot] f4fd256
fix(google): align blocked generation handling
rosetta-livekit-bot[bot] 43de72e
fix(google): skip contentless stream chunks
rosetta-livekit-bot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/agents-plugin-google': patch | ||
| --- | ||
|
|
||
| fix(google): surface Gemini content blocking and empty generation failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴
responseGeneratedset totrueunconditionally, suppressing "no response" error for empty partsresponseGeneratedis set totrueon line 450 before checking whether#parsePartreturned a non-null chunk. This means if Gemini returnscandidate.content.partscontaining parts that all parse tonull(e.g., parts with neithertextnorfunctionCall, such asexecutableCode,codeExecutionResult, or empty text parts),responseGeneratedbecomestrueand the post-loop "no response generated" error at line 458 is never thrown.In contrast, the old code tracked this with
chunksYieldedwhich was only set totrueinside theif (chatChunk)block, so it correctly detected and retried when parts existed but produced no meaningful output. The new code silently completes the stream with zero content chunks enqueued.Was this helpful? React with 👍 or 👎 to provide feedback.