signer: Add price ceilings - #4014
Merged
Merged
Conversation
Add optional maxPrice fields to payment requests and auth webhook responses. This works in conjunction with the signer-configured max; if all three are present, the minimum is effectively used. Also cap the session price at the initial price, since orchestrators should also fix the price at session start, so there is no need to accommodate ~2x drift within ValidatePrice. In practice this should not lead to a behavior change.
rickstaa
reviewed
Aug 11, 2026
rickstaa
reviewed
Aug 11, 2026
rickstaa
reviewed
Aug 11, 2026
rickstaa
reviewed
Aug 11, 2026
rickstaa
reviewed
Aug 11, 2026
rickstaa
reviewed
Aug 11, 2026
Collaborator
Author
|
The x264 git repo went offline which broke tests / CI, so had to update LPMS (livepeer/lpms#451) and then in f4dde49 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4014 +/- ##
===================================================
+ Coverage 35.46423% 35.51633% +0.05210%
===================================================
Files 174 174
Lines 45161 45213 +52
===================================================
+ Hits 16016 16058 +42
- Misses 27871 27880 +9
- Partials 1274 1275 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional maxPrice fields to payment requests and auth webhook responses. This works in conjunction with the signer-configured max; if all three are present, the minimum is effectively used.
Also cap the session price at the initial price, since orchestrators should also fix the price at session start, so there is no need to accommodate ~2x drift within ValidatePrice. In practice this should not lead to a behavior change.