Skip to content

signer: Add price ceilings - #4014

Merged
j0sh merged 4 commits into
masterfrom
ja/signer-max-price
Aug 12, 2026
Merged

signer: Add price ceilings#4014
j0sh merged 4 commits into
masterfrom
ja/signer-max-price

Conversation

@j0sh

@j0sh j0sh commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Add optional maxPrice fields to payment requests and auth webhook responses. This works in conjunction with the signer-configured max; if all three are present, the minimum is effectively used.

Also cap the session price at the initial price, since orchestrators should also fix the price at session start, so there is no need to accommodate ~2x drift within ValidatePrice. In practice this should not lead to a behavior change.

Add optional maxPrice fields to payment requests and auth webhook
responses. This works in conjunction with the signer-configured max;
if all three are present, the minimum is effectively used.

Also cap the session price at the initial price, since orchestrators
should also fix the price at session start, so there is no need to
accommodate ~2x drift within ValidatePrice. In practice this should
not lead to a behavior change.
@j0sh
j0sh requested a review from rickstaa August 7, 2026 22:33
@github-actions github-actions Bot added go Pull requests that update Go code docs labels Aug 7, 2026
Comment thread doc/remote-signer.md
Comment thread doc/remote-signer.md
Comment thread doc/remote-signer.md
Comment thread server/remote_signer.go
Comment thread server/remote_signer.go
Comment thread server/remote_signer.go Outdated

@rickstaa rickstaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j0sh valuable addition which makes sense. Just left some minor comments but can be merged regardless.

@j0sh

j0sh commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

The x264 git repo went offline which broke tests / CI, so had to update LPMS (livepeer/lpms#451) and then in f4dde49

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.51633%. Comparing base (cc49228) to head (77fae56).

Files with missing lines Patch % Lines
server/remote_signer.go 94.54545% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #4014         +/-   ##
===================================================
+ Coverage   35.46423%   35.51633%   +0.05210%     
===================================================
  Files            174         174                 
  Lines          45161       45213         +52     
===================================================
+ Hits           16016       16058         +42     
- Misses         27871       27880          +9     
- Partials        1274        1275          +1     
Files with missing lines Coverage Δ
server/remote_signer.go 67.07566% <94.54545%> (+1.62944%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc49228...77fae56. Read the comment docs.

Files with missing lines Coverage Δ
server/remote_signer.go 67.07566% <94.54545%> (+1.62944%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh
j0sh merged commit 310d90a into master Aug 12, 2026
19 checks passed
@j0sh
j0sh deleted the ja/signer-max-price branch August 12, 2026 03:09
@rickstaa

Copy link
Copy Markdown
Member

The x264 git repo went offline which broke tests / CI, so had to update LPMS (livepeer/lpms#451) and then in f4dde49

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants