server: settle live payment before LV2V EOS - #4017
Open
fastagents wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settle the final live V2V payment interval before the gateway publishes EOS and
cancels the stream context.
Problem
The gateway currently handles
EOSReaderbefore the normal per-segment paymentcall. Meanwhile, the orchestrator accounts payment units from elapsed time when
it receives the next segment.
A delayed final partial segment followed by EOS can therefore cause the
orchestrator to account an interval that the gateway never funds. If the
remaining balance is insufficient, the stream may close with an
insufficient-balance error during normal EOS handling.
Changes
EOS.
overlapping settlement.
cancellation.
Testing
go test ./server -run '^TestLivePaymentProcessor' -count=1go test -race ./server -run '^TestLivePaymentProcessor' -count=1go test ./server -count=1