fix: create Pool on demand + nullable Transaction.to (combined production fix) - #250
fix: create Pool on demand + nullable Transaction.to (combined production fix)#250rickstaa wants to merge 2 commits into
Conversation
Defensive patch. newRound() builds a Pool per active transcoder via a non-deterministic eth_call enumeration that can miss one, leaving reward() to abort on the null Pool and ticketBroker to drop fees. createOrLoadPool() rebuilds the missing Pool on demand in newRound(), reward(), and ticketBroker() so no handler aborts. The deterministic root fix is tracked in #248.
Contract-creation txs have no recipient, so `event.transaction.to` is null and graph-node aborted on the non-nullable `Transaction.to`. `null` is the correct value (matches graph-ts `Address | null`); no mapping change needed.
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Subgraph Studio preview deployed
curl -H 'Content-Type: application/json' \
-d '{"query":"{ protocol(id: \"0\") { inflation } }"}' \
https://api.studio.thegraph.com/query/31909/livepeer-ci/pr-250-5a2a978-29782604511 |
1 participant
Combined production fix — the branch to deploy/verify. Bundles both crash fixes so a resync from genesis clears both:
createOrLoadPool: rebuild a missing Pool on demand soreward()/ticketBroker()never abort on a null Pool (the halt at 144056642).Transaction.tonullable for contract-creation txs (the halt at 485100965).144056642 comes before 485100965, so both fixes must ship together for a clean resync from genesis.
Supersedes #247 (same combination, but with the inline guard #246 instead of the
createOrLoadPoolhelper #249).The deterministic root fix for the pool enumeration is tracked in #248.
🤖 Generated with Claude Code