[HIP] Add execution test for setcc f64 -> setcc i32 reduction#378
Open
zGoldthorpe wants to merge 5 commits intollvm:mainfrom
Open
[HIP] Add execution test for setcc f64 -> setcc i32 reduction#378zGoldthorpe wants to merge 5 commits intollvm:mainfrom
zGoldthorpe wants to merge 5 commits intollvm:mainfrom
Conversation
Adds a test to measure the performance effects of llvm/llvm-project#188356.
arsenm
reviewed
Apr 7, 2026
Note that upper bound for lt comparisons must be guaranteed nnan (and moreover this needs to be recognised by the optimisation, which currently uses computeKnownBits)
arsenm
reviewed
Apr 22, 2026
| struct ConstLo32Z { | ||
| static __host__ __device__ bool check(double x, double y) { | ||
| bool sel = bitcast<uint64_t>(y) >> 52 == 0; | ||
| double split = sel ? 1.0 : 4.0; |
There was a problem hiding this comment.
test more sample values? Particularly non-inline imm cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to measure the performance effects of llvm/llvm-project#188356.