Fix YUAN2 conversation template stripping message characters#3887
Open
JSap0914 wants to merge 1 commit into
Open
Fix YUAN2 conversation template stripping message characters#3887JSap0914 wants to merge 1 commit into
JSap0914 wants to merge 1 commit into
Conversation
The YUAN2 separator style joined messages with the literal '<n>'
separator and then called ret.rstrip('<n>') to drop the trailing
separator before appending seps[0]. str.rstrip treats its argument
as a set of characters, so it stripped every trailing '<', 'n' and
'>' character, corrupting any message that ended in one of them
(e.g. 'What is the value of n' became 'What is the value of ').
Remove only the trailing '<n>' separator with an explicit suffix
check so message content is preserved.
Adds tests/test_conversation.py covering the YUAN2 template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
YUAN2separator style infastchat/conversation.pyjoins messages withthe literal
<n>separator and then callsret.rstrip("<n>")to drop thetrailing separator before appending
seps[0].str.rstriptreats its argument as a set of characters, not a suffix, so itremoves every trailing
<,n, and>character. Any message that ends in oneof those characters gets corrupted. For example:
The fix removes only the trailing
<n>separator with an explicit suffix check,leaving message content intact.
Related issue number (if applicable)
N/A
Checks
format.shto lint the changes in this PR.Verification (Linux, offline):