Repository navigation
fix(core): validate one-time token organizations at creation - #10027
Open
charIeszhao wants to merge 1 commit into
Open
charIeszhao wants to merge 1 commit into
charIeszhao wants to merge 1 commit into
Conversation
charIeszhao
force-pushed
the
charles-validate-one-time-token-organizations
branch
from
November 16, 2026 09:06
08c4dc4 to
30b499b
Compare
charIeszhao
force-pushed
the
charles-validate-one-time-token-organizations
branch
from
November 17, 2026 03:08
30b499b to
f860f18
Compare
charIeszhao
marked this pull request as ready for review
November 17, 2026 03:08
charIeszhao
requested review from
gao-sun,
simeng-li and
wangsijie
as code owners
November 17, 2026 03:08
wangsijie
approved these changes
Nov 17, 2026
simeng-li
approved these changes
Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10026.
Creating a one-time token with a nonexistent organization ID currently succeeds, then silently skips that organization when the user signs in. Validate all distinct
jitOrganizationIdsat creation and reject the whole request with400 request.invalid_input, identifying missing IDs. This also covers organizations referenced byjitOrganizationRoles, whose entries must belong to that list.Organizations deleted after token creation continue to be skipped when the token is used. Add API and provisioning regression coverage, replace placeholder organization IDs in existing tests with real organizations, and document the stricter creation-time behavior in OpenAPI and a patch changeset.
Depends on #9981. This draft is stacked on its current head (
b958529b6); review only the follow-up fix. Rebase ontomasterafter #9981 merges before marking ready.Testing
Unit tests (40 passed)
Integration regression tests added; execution left to CI, not run locally.
Checklist
.changeset