feat(instance): forward v2 data-engine transport to SPDK create calls - #1616
Draft
abonillabeeche wants to merge 2 commits into
Draft
feat(instance): forward v2 data-engine transport to SPDK create calls#1616abonillabeeche wants to merge 2 commits into
abonillabeeche wants to merge 2 commits into
Conversation
Pass the DataEngineTransport from the imrpc SpdkInstanceSpec through to the spdkrpc EngineCreate/ReplicaCreate calls (new mapper convertIMDataEngineTransportToSPDKDataEngineTransport, zero => TCP), so the manager-selected transport reaches the SPDK layer. Build the SPDK deps with 'pkgdep.sh --rdma' so the runtime image ships libibverbs/librdmacm for the NVMe-oF RDMA transport. Default behavior unchanged (unset => TCP). Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
abonillabeeche
force-pushed
the
rdma-transport
branch
from
August 20, 2026 05:19
faf544b to
c994476
Compare
abonillabeeche
changed the title
Consume the renamed imrpc/spdkrpc TransportType enum and rename the IM-side field/params and the IM->SPDK conversion helper accordingly. No behavior change. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of longhorn/longhorn#13796. Depends on longhorn/types#121 and longhorn/longhorn-spdk-engine#654.
Forward
DataEngineTransportfrom the imrpcSpdkInstanceSpecthrough to the spdkrpc engine/replica create calls (new mapperconvertIMDataEngineTransportToSPDKDataEngineTransport, zero means TCP). Adds the field to the IM client'sInstanceCreateRequestso the manager can select transport declaratively (replaces an earlier env-var stopgap). Build the runtime image withpkgdep.sh --rdmaso it shipslibibverbs/librdmacmfor the RDMA transport. Default behavior unchanged (unset means TCP).Files:
pkg/instance/instance.go,pkg/client/instance.go,package/Dockerfile.