Skip to content

feat: add restrict_host_acl to SpdkInstanceSpec and ReplicaCreateRequest #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hookak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add restrict_host_acl to SpdkInstanceSpec and ReplicaCreateRequest #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 50 additions & 50 deletions generated-py/imrpc/instance_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

484 changes: 242 additions & 242 deletions generated-py/spdkrpc/spdk_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

635 changes: 325 additions & 310 deletions pkg/generated/imrpc/instance.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

3,471 changes: 1,741 additions & 1,730 deletions pkg/generated/spdkrpc/spdk.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions protobuf/imrpc/instance.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ message SpdkInstanceSpec {
// indices, and a salvage_requested flag for RecreateEC semantics.
// Nil for engine, replica, shard, and frontend instances.
ShardGroupSpec shard_group_spec = 15;

// restrict_host_acl - Replica instance: restrict every NVMe-oF subsystem
// the replica exposes to the internal host NQN. False keeps the any-host
// ACL so initiators of older instance managers, which do not present the
// internal host NQN, can still connect during a mixed-version window.
bool restrict_host_acl = 16;
}

message InstanceSpec {
Expand Down
1 change: 1 addition & 0 deletions protobuf/spdkrpc/spdk.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ message ReplicaCreateRequest {
uint64 spec_size = 4;
int32 port_count = 5;
string backing_image_name = 6;
bool restrict_host_acl = 7;
}

message ReplicaDeleteRequest {
Expand Down