refactor: убрано дублирование зависимостей - #181
Merged
Conversation
Olegt0rr
reviewed
Aug 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
PR упрощает сопровождение зависимостей проекта, устраняя дублирование между extras и dev-окружением в pyproject.toml, чтобы версии библиотек обновлялись в одном месте.
Changes:
- Убрано прямое перечисление
fastapi/uvicorn/litestarизdependency-groups.devи заменено на установку через extras. - Добавлен
webhookextra как обратносуместимый алиас (вместо отдельного списка зависимостей). - Обновлён TODO-документ (удалён устаревший пункт).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Рефакторинг extras и dev dependency-group для устранения дублирования зависимостей. |
| doc/todo.md | Удаление устаревшего TODO пункта. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Olegt0rr
approved these changes
Aug 12, 2026
Olegt0rr
left a comment
Collaborator
There was a problem hiding this comment.
Судя по приложенным материалам - действительно должно работать
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
Заблокировано #183 - сначала тот вливаем, потом этот рибейзим |
Contributor
Author
|
@love-apples проблем с ruff больше нет, можно вливать |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что изменилось?
Убрано дублирование зависимостей в
pyproject.toml.Теперь
dependency-groups.devиспользует extras (maxapi[fastapi,litestar]) вместо повторного перечисления зависимостей. Из-за этого версии библиотек больше не нужно обновлять в нескольких местах, а dev-окружение всегда использует те же зависимости, что и пользовательские extras для FastAPI и Litestar.