fix: last_activity_time сделан опциональным - #182
Open
Olegt0rr wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
PR исправляет проблему валидации при get_chat_members, когда среди участников есть удалённый аккаунт (DELETED USER) и поле last_activity_time отсутствует в ответе API. Изменение укладывается в модельную часть SDK (types) и закрепляется регрессионными тестами.
Changes:
- Поле
User.last_activity_timeсделано опциональным (int | None), чтобы отсутствующее значение не ломало парсинг. - Расширены тесты swagger-alignment: добавлены проверки для удалённых пользователей и для ответа
GettedMembersChat.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
maxapi/types/users.py |
Делает last_activity_time опциональным в модели User, устраняя ошибку валидации для удалённых пользователей. |
tests/test_swagger_alignment.py |
Добавляет регрессионные тесты для кейса #179 (удалённый участник без last_activity_time) и проверку GettedMembersChat. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #179