Print announce error response#11878
Merged
SmallJoker merged 6 commits intoJan 1, 2022
Merged
Conversation
sfan5
reviewed
Dec 21, 2021
sfan5
reviewed
Dec 21, 2021
SmallJoker
reviewed
Dec 30, 2021
SmallJoker
approved these changes
Jan 1, 2022
LoneWolfBT
pushed a commit
to MT-CTF/minetest
that referenced
this pull request
Feb 13, 2022
Fix HTTPFetch caller and request ID to 64 bits Check that allocated caller ID is not DISCARD Print body if serverlist request returns error Don't print control characters from HTTP responses Document special HTTPFetch caller IDs Allow unicode to be printed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This it just the HTTPFetch changes from #11342.
Note that this does make one change to HTTP Fetch that would be visible to the Lua API: HTTP responses with a 400+ code don't cause
succeededto be set tofalseanymore, only an actual cURL failure (e.g. connection refused) will cause that.lua_api.txtdoesn't define what preciselysucceededmeans, though, so either implementation could be correct. It could be restored to the previous behavior or we could leave it if this implementation makes more sense (to me it seems like it makes more sense this way, because the request itself succeeded, the server just responded with a failure code).