Speed up phase_zinc_depscheck - #119
Merged
jadenPete merged 1 commit intoSep 14, 2026
Merged
Conversation
jjudd
reviewed
Sep 14, 2026
jjudd
approved these changes
Sep 14, 2026
jjudd
left a comment
jjudd
left a comment
There was a problem hiding this comment.
LGTM. I think there's a comment that could use some editing, but otherwise no concerns.
Previously, this phase ran `_add_args_for_depscheck_labeled_group` (which calls `Args#add`) for every transitive compile JAR of every Scala target in the build graph. This is far less efficient than calling `Args#add_all` once. We used to do this, but stopped doing so in `61ccf28f04309107f4d5b9a85d2ba883996d68f1` because Bazel changed how labels are formatted (canonical vs. apparent) in different contexts. This change preserves that bug fix, but fixes the inefficiency of the implementation.
jadenPete
force-pushed
the
jpeterson-speed-up-scaladepscheck-analysis
branch
from
September 14, 2026 18:38
77ffb02 to
242c930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this phase ran
_add_args_for_depscheck_labeled_group(which callsArgs#add) for every transitive compile JAR of every Scala target in the build graph.This is far less efficient than calling
Args#add_allonce. We used to do this, but stopped doing so in 61ccf28 because Bazel changed how labels are formatted (canonical vs. apparent) in different contexts.This change preserves that bug fix, but fixes the inefficiency of the implementation.